/sqlitebrowser

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Browse Data tab: Query re-executed when filter cell receives focus #1187

Closed
pamtbaau opened this Issue Oct 22, 2017 · 3 comments

Comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
3 participants
@pamtbaau @MKleusberg @chrisjlocke
@pamtbaau
Copy link

pamtbaau commented Oct 22, 2017

Details for the issue

When focus changes in filter cells in the browse tab, the query gets rerun. Not really harmful, but unnecessary and causing screen flicker. Also, when scrolled, scrolling get undone.

Useful extra information

I'm opening this issue because:

  • DB4S is crashing
  • DB4S has a bug
  • DB4S needs a feature
  • DB4S has another problem

I'm using DB4S on:

  • Windows: ( version: 10 )
  • Linux: ( distro: ___ )
  • Mac OS: ( version: ___ )
  • Other: ___

I'm using DB4S version:

  • 3.10.1
  • 3.10.0
  • 3.9.1
  • Other: 3.10.99

I have also:

MKleusberg added a commit that referenced this issue Oct 22, 2017

@MKleusberg
Make sure to not re-run the query if the filters haven't changed 
When changing between the filter line edits in the Browse Data tab, make
sure to only re-run the SQL query if the value of the filter line edits
have actually changed.

See issue #1187.
d126e86
@MKleusberg

This comment has been minimized.

Sign in to view
Copy link
Member

MKleusberg commented Oct 22, 2017

Thanks for opening all these issues! As much as I would like to an issue number <200, these are all good observations 😉

That said, I believe this issue is fixed now. Can you download tomorrow's nightly build and check if it's stopping the re-execution of queries for you? 😄
@pamtbaau

This comment has been minimized.

Sign in to view
Copy link
Author

pamtbaau commented Oct 27, 2017

Tested on 3.10.99 and issue is fixed. Well done and thanks.

@chrisjlocke chrisjlocke closed this Oct 27, 2017

@MKleusberg

This comment has been minimized.

Sign in to view
Copy link
Member

MKleusberg commented Oct 27, 2017

Thanks for testing 😄
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment