New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature request: Add an option to filter empty records through the filter GUI (Browse data) #1189

Closed
SilvioGrosso opened this Issue Oct 22, 2017 · 5 comments

Comments

Projects
None yet
4 participants
@SilvioGrosso
Copy link

SilvioGrosso commented Oct 22, 2017

Hello everyone,

Please, add an option to Filter empty records through the "Browse data" GUI.

Currently, on Windows 10 - Windows 7 (64bit .exe installer) I can easily filter all empty cells in my tables by writing some simple SQL code.
E.g.
SELECT * FROM mytable WHERE columnA = ' '

On the contrary, it looks like this option is not implemented yet as filter through the GUI.
On the "browse data" grid GUI I am able to select NULL and NOT NULL values whereas I am unable to filter empty records in my Sqlite database.
I have read the Wiki short "manual" but this option is not listed in the filter section.

I am testing the 3.10.99 version (on Windows 7 - 10)
QT 5.7.1
Sqltie 3.20.0

Thanks a lot !

@karim karim added the enhancement label Oct 24, 2017

@karim

This comment has been minimized.

Copy link
Member

karim commented Oct 24, 2017

Sounds like a useful addition to DB4S filter. 😄

Do you have any suggestion about which operator we should use? Something like ='' maybe?

In the meantime, you can try sorting the column (by clicking on its name) and it should show you all the empty fields together. Not ideal I know but it works. :)

@SilvioGrosso

This comment has been minimized.

Copy link
Author

SilvioGrosso commented Oct 24, 2017

MKleusberg added a commit that referenced this issue Oct 31, 2017

Add support for filtering for empty strings in Browse Data tab
Add special filters "=''" and "<>''" to the filter row in the Browse
Data tab for filtering for empty string and non-empty-string fields. The
latter also excludes all NULL fields because that's how SQLite works.

See issue #1189.
@MKleusberg

This comment has been minimized.

Copy link
Member

MKleusberg commented Oct 31, 2017

Just added the two filters as suggested by @SilvioGrosso. I hope I didn't break anything else during the process because the filter code is already quite complex 😉 A quick warning: "<>''" also leaves out all records with a NULL field because SQLite implicitly converts them to empty strings when doing string comparisons. I don't think it's a big problem and there's not much we can do about it without making this overly complicated.

@SilvioGrosso Can you check if it's working for you as expected with tomorrow's nightly build? 😄

And anybody interested in updating the Wiki article?

@SilvioGrosso

This comment has been minimized.

Copy link
Author

SilvioGrosso commented Nov 1, 2017

Hello everyone !
You made my day :-)

Just tested on Windows 10 (64 bit) with today's daily build.
Everything is filtered as expected.

I have uploaded a video on YouTube to show this new feature (I hope you don't mind):
https://www.youtube.com/watch?v=UtP0Qg0wNpw

Many thanks indeed !

mgrojo added a commit that referenced this issue Nov 1, 2017

@MKleusberg

This comment has been minimized.

Copy link
Member

MKleusberg commented Nov 1, 2017

Awesome, I'm glad I could help 😄 Thanks a lot for testing!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment