Retain display formats #1202
Retain display formats #1202
Conversation
…cell as filter in this column. This allows quick filtering by selected values.
…get internal cell data and check for the NULL special case.
Reviewed translation following guidelines the KDE Spanish Translation Team: https://es.l10n.kde.org/ Warnings raised by linguist have been solved.
…ed table name is actually a view. Now it is checked the object type before the cast. This avoids the crash and the field name is obtained for each case.
combo instead of falling back to Custom. The display format items have been reorganized in groups with separators in between. This is because the strict alphabetical order looses sense in the translations.
… into edit_display_format
|
Excellent, that looks like it'll be really useful. 😄 |
There was a problem hiding this comment.
Thanks again 👍 I've just found one cosmetic issue in the code. When that's fixed, this can be merged 😄
There were quite a few people complaining about the fact that the Display Format dialog would always show "Custom" even though you selected one from the list. So this is definitely a welcomed fix 😉
src/ColumnDisplayFormatDialog.cpp
Outdated
| ui->comboDisplayFormat->insertSeparator(ui->comboDisplayFormat->count()); | ||
| ui->comboDisplayFormat->addItem(tr("Custom"), "custom"); | ||
| formatName = "custom"; | ||
| } |
There was a problem hiding this comment.
Just one minor thing: here and above in the foreach loop you're mixing spaces and tabs for indentation which makes the indentation look wrong if the tab width is not set to 8 spaces. Can you change the tabs to 4 spaces instead? 😄 By the way, if you're using Qt Creator you can go to the "Projects" panel (big button on the left), there click "Editor" in the "Project Settings" section, and then set the Tab policy to "Spaces only", the Tab size to "4" and the Indent Size to "4". That changes it just for the sqlitebrowser project and keeps the old settings for all your other projects. That's how I configured it, too 😉
There was a problem hiding this comment.
I wasn't aware that Emacs was inserting spaces. I've already changed its settings, so it no longer does that. I don't use Qt Creator for the moment, but I will give it a try.
There was a problem hiding this comment.
If you're used to Emacs, I'd stick with that (and I say that as a Vim-person 😉) but Qt Creator is definitely worth giving a try, especially when editing the .ui files 😄
There was a problem hiding this comment.
Some tasks are easier with those visual IDEs, but I know too many Emacs tricks and powerful commands for just abandoning it 😄
src/ColumnDisplayFormatDialog.cpp
Outdated
| ui->comboDisplayFormat->addItem(tr("Custom"), "custom"); | ||
| ui->comboDisplayFormat->setCurrentIndex(ui->comboDisplayFormat->findData("custom")); | ||
| QString formatName; | ||
| foreach (const QString &formatKey, formatFunctions.keys()) { |
There was a problem hiding this comment.
You can also use a range-based for loop from C++11 here since we don't have to support older compilers anymore. The foreach provided by Qt is slower than the C++11 one because it creates a copy of the entire map before iterating over the copy. It's not a big deal though in this case.
There was a problem hiding this comment.
Perfect. I've committed the improvement.
foreach loop from Qt. Cleaned up some tabs inadvertently inserted as indentation.
|
Thanks 😄 And it's merged now 👍 |
If the Colum Display Format Dialog was open again after setting a format, the combo box showed always the format as custom, instead of setting the correct value according to the SQL code. The dialog recognizes now the current format.
The display format items have been reorganized in groups with separators in between. This is because the complete alphabetical order looses sense in the translations, so it is better to group the items by type and then alphabetically.