New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

XML mode for the cell editor #1253

Closed
mgrojo opened this Issue Dec 6, 2017 · 6 comments

Comments

Projects
None yet
2 participants
@mgrojo
Copy link
Contributor

mgrojo commented Dec 6, 2017

Based on the work I've done for the issue #1173, I plan to develop an XML mode for the cell editor. I open this enhancement request so anyone interested in this mode, can share his expectations or ideas about it.

@mgrojo mgrojo self-assigned this Dec 6, 2017

@mgrojo mgrojo added the enhancement label Dec 6, 2017

@justinclift

This comment has been minimized.

Copy link
Member

justinclift commented Dec 6, 2017

Sounds useful. 😄

For XML schema support, do you reckon validation will be complicated?

@mgrojo

This comment has been minimized.

Copy link
Contributor Author

mgrojo commented Dec 6, 2017

I hope it is not too difficult, using the classes that Qt provides. At first, maybe only form correctness will be validated 😉

@justinclift

This comment has been minimized.

Copy link
Member

justinclift commented Dec 6, 2017

😀

I kind of wonder how SVG will turn out. The existing image viewing bits will be able to view it, so an XML mode might make for a safer way to do minor adjustments.

mgrojo added a commit that referenced this issue Dec 15, 2017

Refactoring and find/replace dialog in the JSON editor.
SQL and JSON text editor classes have been refactored. A new parent class
for both editors have been added for the common logic implementable without
depending on the specific lexer.

The only visible effect of this change should be that the JSON editor
(issue #1173) now has the same find/replace dialog as the SQL editor.

This prepares for the implementation of the XML editor (issue #1253).

mgrojo added a commit that referenced this issue Dec 23, 2017

XML mode for the cell editor
The new editor mode shares the same Scintilla widget as the JSON mode.
The JsonTextEdit class has been generalised. Future modes supported by
Scintilla could be added with the current pattern. As a consequence, the
EditMode is not always equal to the current stacked widget.

Some code in EditDialog has been refactored, so it is easier to understand
and modified with so many modes. textNullSet has been replaced by the use
of dataType as Null.

SVG is promoted to a new recognised data type, so it can be edited in the
XML mode.

The XML data is formatted and validated following the pattern established
by the JSON mode.

New modules are needed by the XML mode: the Qt XML module and some new
Scintilla files required by the HTML/XML lexer.

The indent_compact was incorrectly named in Setting::getDefaultValue.

See issue #1253.

mgrojo added a commit that referenced this issue Jan 27, 2018

XML mode for the cell editor
The new editor mode shares the same Scintilla widget as the JSON mode.
The JsonTextEdit class has been generalised. Future modes supported by
Scintilla could be added with the current pattern. As a consequence, the
EditMode is not always equal to the current stacked widget.

Some code in EditDialog has been refactored, so it is easier to understand
and modified with so many modes. textNullSet has been replaced by the use
of dataType as Null.

SVG is promoted to a new recognised data type, so it can be edited in the
XML mode.

The XML data is formatted and validated following the pattern established
by the JSON mode.

New modules are needed by the XML mode: the Qt XML module and some new
Scintilla files required by the HTML/XML lexer.

The indent_compact was incorrectly named in Setting::getDefaultValue.

See issue #1253.
@justinclift

This comment has been minimized.

Copy link
Member

justinclift commented Feb 1, 2018

Just had a thought. If we take some screenshots of the XML and JSON editors, we can send a tweet about them and probably get a few extra people testing them out.

Might be useful for figuring out that button placement thing. 😄

@mgrojo

This comment has been minimized.

Copy link
Contributor Author

mgrojo commented Feb 1, 2018

Yeah, why not.

@mgrojo

This comment has been minimized.

Copy link
Contributor Author

mgrojo commented Sep 28, 2018

I'm going to close this, since nobody has reported problems and it's ready for release. The only improvement that I'm aware of is detecting XML in an efficient way, so the mode can be switched automatically to XML when appropriate, but it's better to make the cut here for the 3.11.0 release.

Regarding the button placement thing, maybe it's not so important when nobody more has paid attention to it 😄

@mgrojo mgrojo closed this Sep 28, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment