Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Language keywords should autocomplete to upper case #1287

Closed
fulldecent opened this issue Jan 5, 2018 · 2 comments
Closed

Language keywords should autocomplete to upper case #1287

fulldecent opened this issue Jan 5, 2018 · 2 comments

Comments

@fulldecent
Copy link

@fulldecent fulldecent commented Jan 5, 2018

Test case:

  1. Open query editor
  2. Type sel
  3. Wait

Expected result:

Autocomplete suggests SELECT.

Actual result:

Autocomplete suggests select.

Discussion:

The SQLite documentation for interpreting SQL uses uppercase keywords. So we can assume that is the preferred style.

@justinclift
Copy link
Member

@justinclift justinclift commented Jan 5, 2018

Thanks @fulldecent. This seems like a duplicate of #1238. 😄

mgrojo added a commit that referenced this issue Jan 6, 2018
Added a new setting for completing the SQL keywords in upper case (default
being true).

Scintilla setAutoCompletionCaseSensitivity is set to false. Otherwise the
completion is only done in lowercase when both case versions are added,
or if only upper case version is added, writing lower case letters does
not use the upper case version of the word in the completion list. This
change doesn't have apparently any downside, since SQL is actually case
insensitive.

Consequently the list of keywords is only added in one of the two letter
case versions, depending on the new setting value.

The new preference check-box is only enabled when the auto-complete
check-box is checked.

See issues #1238 and #1287.
@fulldecent
Copy link
Author

@fulldecent fulldecent commented Jan 7, 2018

Definitely a dupe, closing.

And also thanks for the fix!

@fulldecent fulldecent closed this Jan 7, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
2 participants