New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SQL doesn't get saved or reminded on project exit #1386

Open
DaleEMoore opened this Issue May 11, 2018 · 11 comments

Comments

Projects
None yet
6 participants
@DaleEMoore
Copy link

DaleEMoore commented May 11, 2018

Details for the issue

Opened a recent project.
Changed the SQL.
Exited the program.
No prompt for "Save your stupid changes?"
Lost all that work.
Sure would like it if it helped me more with my stupidity!

Useful extra information

I'm opening this issue because:

  • DB4S is crashing
  • DB4S has a bug
  • DB4S needs a feature
  • DB4S has another problem

I'm using DB4S on:

  • Windows: ( version: ___ )
  • Linux: ( distro: ___ )
  • Mac OS: ( version: ___ )
  • Other: ___

I'm using DB4S version:

  • 3.10.1
  • 3.10.0
  • 3.9.1 (Why doesn't this bug generator build the correct version?
  • Other: ___

I have also:

@justinclift

This comment has been minimized.

Copy link
Member

justinclift commented May 11, 2018

Oh good point. That sounds like a good idea. 😄

Btw, what does "Why doesn't this bug generator build the correct version?" mean?

@chrisjlocke

This comment has been minimized.

Copy link
Contributor

chrisjlocke commented May 11, 2018

what does "Why doesn't this bug generator build the correct version?" mean?

I assume that if the user was using a v3.9.1 product, clicking 'Help | Bug Report...' would pre-fill in the 3.9.1 version box in the bug template... if they were using a v3.10.1 product, etc, etc....
Don't know if the URL submitted can use different templates, and then have templates for each version? .../issues/new?template=v3.9.1, etc....

@DaleEMoore

This comment has been minimized.

Copy link
Author

DaleEMoore commented May 11, 2018

Thanks @justinclift and @chrisjlocke for your questions, thoughts and responses!

My workstation installation of "DB Browser for SQLite" knows its own version which I can get by going to menu item Help, About. So when I select the menu item Help, Bug report and it creates a new bug report at https://github.com/sqlitebrowser/sqlitebrowser/issues/new; I would like the new bug report to contain the version of "DB Browser for SQLite" that's invoked it. Hopefully it would fill in all the appropriate versions:

Version 3.9.1
Qt Version 5.6.1
SQLite Version 3.15.2
Ubuntu 17.10 (available in /etc/issue)

Thanks for all your hard work!

@justinclift

This comment has been minimized.

Copy link
Member

justinclift commented May 11, 2018

That's a good idea too. Shouldn't be too hard for us to figure out the right field names to embed in the link to the new issue page.

@justinclift

This comment has been minimized.

Copy link
Member

justinclift commented May 11, 2018

Actually... that might be tricky after all. The server side isn't doing anything with values it receives, so there's no chance of the GitHub server populating fields with provided values.

To get this working, we'd likely need DB4S to fully populate the entire bug report field as that's the only way I'm thinking of we could automatically include the info. It'd probably take a bunch of effort, and only give a mediocre result. *sigh*

@DaleEMoore

This comment has been minimized.

Copy link
Author

DaleEMoore commented May 11, 2018

@justinclift

This comment has been minimized.

Copy link
Member

justinclift commented May 11, 2018

Hmmm, GitHub do have a contact form:

    https://github.com/contact

I've used it occasionally, and they've always gotten back to me. So it's worth a shot. 😄

@DaleEMoore

This comment has been minimized.

Copy link
Author

DaleEMoore commented May 11, 2018

@karim

This comment has been minimized.

Copy link
Member

karim commented May 13, 2018

We can use some query parameters when opening a new issue. So far I have tested template, labels, title, and assignee. You can use one or all of them.

Example

https://github.com/sqlitebrowser/sqlitebrowser/issues/new?template=Bug_report.md&labels=bug,windows&assignee=karim&title=New+Bug+Report

We can generate the link dynamically on the app. For example, on Windows, it should add windows label, etc.

MKleusberg added a commit that referenced this issue May 16, 2018

Update Report bug link to include the system information (#1388)
When reporting an issue from the application, via the menu 'Help | Bug report', the new link will add the label 'bug' and include the system information automatically.

See issue #1386

@mgrojo mgrojo referenced this issue Oct 6, 2018

Open

CTRL-S does not save sql files #871

3 of 13 tasks complete
@martrs

This comment has been minimized.

Copy link

martrs commented Nov 27, 2018

It looks like SQL queries get saved, but when loading, they don't load.

I verified this by looking at the saved file, which seems to be XML format, with <tab_sql><sql name="SQL 1">SQL queries</sql>..

@justinclift

This comment has been minimized.

Copy link
Member

justinclift commented Nov 27, 2018

Oh, that sounds like a bug.

@justinclift justinclift added the bug label Nov 27, 2018

@mgrojo mgrojo self-assigned this Jan 11, 2019

mgrojo added a commit that referenced this issue Jan 17, 2019

Ask user about saving any modified data in SQL tabs
User is asked once for saving modified SQL tabs not attached to a file to
the current project file (or to a new project file, when there isn't any
yet).

For each tab linked to a file, the user is asked to save the changes to the
file.

The asking is performed when the tab is closed, or when the application
is closing.

The modified attribute of the editor is set to false when the data is
saved or has just been loaded in the editor.

See issues #1386 and #1706
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment