Join GitHub today
GitHub is home to over 31 million developers working together to host and review code, manage projects, and build software together.Sign up
Copy from edit database cell broken in binary mode #1485
Details for the issue
What did you do?
What did you expect ?
Able to copy what I see.
What did you see instead?
a) if I select in either the text or the binary side, the other is also selected. This is OK.
e) If I export, I get just the text (and only Save as *.txt & *.* as export options):
This seems to be a regression from #1438 -- I thought that had save as binary implemented, with save as text in the pipeline.
The data in this cell is actually text - I selected Binary to make sure than there is not glyph-aliasing going on. So perhaps you are choosing an export mode based on what you think the cell contents is, rather than what I selected. It's great to have you guess what the cell contents is & select a mode based on the guess.
But if I select Binary mode, I expect export to be .bin (binary) as an option. Just because something looks like text doesn't mean that I want it treated that way (e.g. line ending conversions.) In general, once the user selects a mode, DB4S should treat the data as specified by the user, not according to any guess it made.
(Context: I wanted to provide the hex dump as supporting data in a commit to another project.)
FWIW: The database is open read-only.
Useful extra information
The info below often helps, please fill it out if you're able to. :)
What operating system are you using?
What is your DB4S version?
Did you also
added a commit
Sep 29, 2018
added a commit
Sep 30, 2018
@tlhackque, I managed to implement the part about:
A new action (shortcut Ctrl+Shift+C) included in the context menu has been added for copying the selection, including the addresses, the hex digits and the ASCII part.
I've noted these behaviours of the qhexedit library that we are using, and I cannot change without modifying the library (this may be what the user wants or not):
Nevertheless, I had to make a change for being able to copy using the context menu and I'll make a pull request, so it can be added to the official library.
Could you try the new action in tomorrow's nightly build and confirm that it's working for you?