Copy from edit database cell broken in binary mode #1485
Details for the issue
What did you do?
What did you expect ?
Able to copy what I see.
What did you see instead?
a) if I select in either the text or the binary side, the other is also selected. This is OK.
e) If I export, I get just the text (and only Save as *.txt & *.* as export options):
This seems to be a regression from #1438 -- I thought that had save as binary implemented, with save as text in the pipeline.
The data in this cell is actually text - I selected Binary to make sure than there is not glyph-aliasing going on. So perhaps you are choosing an export mode based on what you think the cell contents is, rather than what I selected. It's great to have you guess what the cell contents is & select a mode based on the guess.
But if I select Binary mode, I expect export to be .bin (binary) as an option. Just because something looks like text doesn't mean that I want it treated that way (e.g. line ending conversions.) In general, once the user selects a mode, DB4S should treat the data as specified by the user, not according to any guess it made.
(Context: I wanted to provide the hex dump as supporting data in a commit to another project.)
FWIW: The database is open read-only.
Useful extra information
The info below often helps, please fill it out if you're able to. :)
What operating system are you using?
What is your DB4S version?
Did you also
The text was updated successfully, but these errors were encountered:
When the data source is the hex editor we are able to save whatever data type as shown in the widget, so additionally to set the filters according to the data type a "Hex dump files (*.txt)" filter option is added. If the user selects this option for saving, the hexadecimal dump of the widget content is saved to the file. Note that the check must be performed using the selected filter by the user and not the file ending, which would be the same for text data exported as plain text. The Null case is disregarded as it is useless for exporting. See issues #1438 and #1485
…1485 Added a new copy action to the binary editor context menu for copying the selected text as seen by the user, instead of the stream of hexadecimal digits copied by default by qhexedit. In order to support copying from the context menu, qhexedit has been modified for not resetting the selection when the left mouse button is pressed. This will be converted to a pull request to qhexedit afterwards. See related issue #1485
@tlhackque, I managed to implement the part about:
A new action (shortcut Ctrl+Shift+C) included in the context menu has been added for copying the selection, including the addresses, the hex digits and the ASCII part.
I've noted these behaviours of the qhexedit library that we are using, and I cannot change without modifying the library (this may be what the user wants or not):
Nevertheless, I had to make a change for being able to copy using the context menu and I'll make a pull request, so it can be added to the official library.
Could you try the new action in tomorrow's nightly build and confirm that it's working for you?
It wasn't definitely a release-blocker, and in fact, we didn't mind for releasing it