Join GitHub today
GitHub is home to over 31 million developers working together to host and review code, manage projects, and build software together.Sign up
Wrong symbol for single quotewhen saving to sql file #1502
Details for the issue
the SQL file obtained via the "Save database to an SQL file" uses ` (U+0060, accent grave) instead of ' (U+0020) apostrophe
Useful extra information
I'm opening this issue because:
I'm using DB4S on:
I'm using DB4S version:
I have also:
Yep, we have changed quotes throughout the entire program, including the SQL export. So the nightly is worth a try
Just mentioning one exception to the changes in the nightly build: if the original table definition uses e.g. grave quotes and you configured the application to use double quotes (the new default), it'll export double quotes unless the table or index definition cannot be fully parsed. So if our parser notices something it doesn't fully understand we leave the statement as-is to avoid any loss of information. For triggers and views that's always the case by the way. So these statements would always be exported using grave quotes if that's how they were defined in the first place.
Just exported a database to SQL using the nightly (6 Sep) and while CREATE TABLE and INSERT statements use the user-defined option, CREATE VIEW doesn't.
Also (I'm on Windows) there was no option to set carriage return options, so all the SQL has got squished into one line - note the 'tn3.orderBy=3left join contactsData'.....(etc). It is valid SQL though (it all imported fine) but its just the 'wrong' line terminators for Windows...
@chrisjlocke You're right - but it's supposed to be like that
added a commit
Sep 6, 2018
That should be solved with my last commit. Could you confirm it?