Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Save attached DB info in project file #1532

Closed
n-arakawa opened this issue Sep 14, 2018 · 7 comments
Closed

Save attached DB info in project file #1532

n-arakawa opened this issue Sep 14, 2018 · 7 comments
Assignees

Comments

@n-arakawa
Copy link

@n-arakawa n-arakawa commented Sep 14, 2018

Describe the new feature

It' tedious to attach DB and assign name over and over!

Additional info

Please answer these questions before submitting your feature request.

Is your feature request related to an issue? Please include the issue number.

Does this feature exist in another product or project? Please provide a link.

Do you have a screenshot? Please add screenshots to help explain your idea.

@justinclift justinclift changed the title save atteced DB info in project file Save attached DB info in project file Sep 14, 2018
@justinclift
Copy link
Member

@justinclift justinclift commented Sep 14, 2018

Good idea @n-arakawa. 😄

@mgrojo mgrojo self-assigned this Sep 15, 2018
MKleusberg added a commit that referenced this issue Sep 27, 2018
We were already saving information on tables, etc. of attached
databases, so it only makes sense to save the path and name of the
databases as well.

See issue #1532.
@MKleusberg
Copy link
Member

@MKleusberg MKleusberg commented Sep 27, 2018

I agree, this is especially a good idea since we already save all the other aspects regarding attached databases (like view and table settings) to the project file. It's just the path and name which are missing. So I have just added the required bits 😄 Can you check tomorrow's nightly build and re-save your project file after attaching the database(s), then load it again to see if it's working as expected now, @n-arakawa?

@mgrojo
Copy link
Member

@mgrojo mgrojo commented Sep 27, 2018

So easy 😄 I took a look and thought how to do it using our API but didn't find a way. Using the SQLite is straightforward, I see now. 👍

@MKleusberg
Copy link
Member

@MKleusberg MKleusberg commented Sep 27, 2018

Haha 😄 I was thinking that we should maybe add an equivalent for querySingeValueFromDb() someday to query multiple rows. That would offer a cleaner and more obvious API for cases like this one.

@mgrojo
Copy link
Member

@mgrojo mgrojo commented Sep 27, 2018

Yes, I meant something in our classes for getting the attached database, but you are right too.

@n-arakawa
Copy link
Author

@n-arakawa n-arakawa commented Sep 28, 2018

Fine!
It's OK with commit b6d436d.
Thank you all for efforts.

tested on Ubuntu 1804
Version 3.10.99 (Sep 29 2018)
Qt Version 5.9.5
SQLCipher Version 3.4.1 (based on SQLite 3.15.2)

@justinclift
Copy link
Member

@justinclift justinclift commented Sep 29, 2018

Excellent. Good work everyone! 😄

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
4 participants