New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add schema name when "Drag and Drop Qualified Names" for fields of atacched tables #1534

Closed
n-arakawa opened this Issue Sep 14, 2018 · 5 comments

Comments

Projects
None yet
2 participants
@n-arakawa
Copy link

n-arakawa commented Sep 14, 2018

Describe the new feature

I recently notice the "Drag and Drop Qualified Names" from DB schema is implemented.
Thanks!

It is more convenient to add a schema name for attached database!

Additional info

Please answer these questions before submitting your feature request.

Is your feature request related to an issue? Please include the issue number.

Does this feature exist in another product or project? Please provide a link.

Do you have a screenshot? Please add screenshots to help explain your idea.

@mgrojo

This comment has been minimized.

Copy link
Contributor

mgrojo commented Sep 15, 2018

I considered including also the schema in field names (except for main). Finally I felt that it was too verbose and left only the table name when the qualified option is enabled. But no strong opinion with that, it can be changed. I wonder now if we need an additional option for this or people will be satisfied with selecting between fully qualified and not qualified at all.

By the way, with the current version, you can control-select the schema and the field to get the fully qualified name.

@mgrojo mgrojo added the enhancement label Sep 15, 2018

@n-arakawa

This comment has been minimized.

Copy link
Author

n-arakawa commented Sep 15, 2018

By the way, with the current version, you can control-select the schema and the field to get the fully qualified name.

To have a good result, it is important to disable qualified option and click items in right order.
(schema -> table -> field)

I wonder now if we need an additional option for this or people will be satisfied with selecting between fully qualified and not qualified at all.

It is not so tedious to delete unnecessary qualifier. So I prefer just two options:

  • just simple, or
  • fully qualified

mgrojo added a commit that referenced this issue Sep 15, 2018

Issue #1534: add schema name for qualified fields dropped from DB Schema
For the "Drag & Drop Qualified Names" option, the schema name for
attached databases is also added for field names dropped from the DB
Schema dock.

@mgrojo mgrojo self-assigned this Sep 15, 2018

@mgrojo

This comment has been minimized.

Copy link
Contributor

mgrojo commented Sep 15, 2018

Ok, qualified means qualified after all. I've added the domain as you suggested.

@n-arakawa

This comment has been minimized.

Copy link
Author

n-arakawa commented Sep 15, 2018

Thanks!
I can get <schema>.<table>.<fileld> when drag and drop a field with 'fully qualified' option on.

commit 9daf265
Version 3.10.99 (Sep 15 2018)
Qt Version 5.9.5
SQLCipher Version 3.4.1 (based on SQLite 3.15.2)

@mgrojo

This comment has been minimized.

Copy link
Contributor

mgrojo commented Sep 15, 2018

Thanks for testing, @n-arakawa. Let's close this, then.

By the way I had to edit your comment to understand. At first, the text between <> did not show up, and I thought it was failing for you 😄

@mgrojo mgrojo closed this Sep 15, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment