Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Completion doesn't work until refresh is pressed in DB #1549

Closed
mgrojo opened this issue Sep 29, 2018 · 8 comments
Closed

Completion doesn't work until refresh is pressed in DB #1549

mgrojo opened this issue Sep 29, 2018 · 8 comments
Assignees
Labels
bug Confirmed bugs or reports that are very likely to be bugs.

Comments

@mgrojo
Copy link
Member

mgrojo commented Sep 29, 2018

Details for the issue

What did you do?

Run DB4S, open a database, click on Execute SQL, type "sel".

What did you expect to see?

The SQL editor proposes "SELECT" as completion.

What did you see instead?

No completion.

If I press F5 in DB Structure, it starts working.

It happens several nightlies ago. It doesn't happen with 3.10.1

Useful extra information

DB4S v3.10.99 (Sep 29 2018) on Windows 7 SP 1 (6.1) (winnt/6.1.7601) [x86_64]
using SQLite Version 3.25.1
and Qt 5.8.0

@mgrojo mgrojo added the bug Confirmed bugs or reports that are very likely to be bugs. label Sep 29, 2018
@mgrojo mgrojo self-assigned this Sep 30, 2018
mgrojo added a commit that referenced this issue Sep 30, 2018
Apparently setLexer is needed for actually activating the QScintilla
completion after application start-up.
@mgrojo
Copy link
Member Author

mgrojo commented Sep 30, 2018

This seems solved. If someone wants to confirm it, I will wait some time before actually closing this.

@mgrojo mgrojo closed this as completed Oct 2, 2018
@MKleusberg
Copy link
Member

I can confirm it's working. There is however another somewhat related bug: when you open DB4S, then load a database via the menu it's working fine, but if you open a database via a command line argument or by file association the auto completion doesn't show you table names and so on from the database until you hit F5. This was mentioned somewhere in an issue but I can't find it now.

@justinclift
Copy link
Member

Should we re-open this until its fixed for the cli and file association opened databases too?

@MKleusberg
Copy link
Member

Yeah, I'll reopen this issue so the point isn't lost. If the other issue I was thinking of if still open and we find it we can close one of them of course.

@mgrojo
Copy link
Member Author

mgrojo commented Oct 5, 2018

if you open a database via a command line argument or by file association the auto completion doesn't show you table names and so on from the database until you hit F5.

I don't reproduce that. Isn't it also fixed with this change?

@mgrojo
Copy link
Member Author

mgrojo commented May 18, 2019

Does someone still reproduce this in some way?

@chrisjlocke
Copy link
Member

Works OK for me - just tested the latest nightly.

@MKleusberg
Copy link
Member

Seems like it's working 😄 I'm just going to close this issue then.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Confirmed bugs or reports that are very likely to be bugs.
Projects
None yet
Development

No branches or pull requests

4 participants