Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

"determining row count" displays forever in Browse Data tab #1654

Closed
justinclift opened this Issue Dec 9, 2018 · 6 comments

Comments

Projects
None yet
3 participants
@justinclift
Copy link
Member

justinclift commented Dec 9, 2018

Noticed a weird edge case just now, while trying out the latest nightly build (2018-12-09) on macOS.

After opening a database that has no tables in it yet (eg very empty database), the Browse Data tab permanently shows the string "determining row count" for the # of rows:

db4s-edge_case_bug1

We'll probably need need to write some kind of catch that recognises when there's no table for display in the Browse Data tab. 😄

@justinclift justinclift added the bug label Dec 9, 2018

@justinclift justinclift added this to the 3.12.0 - Future release milestone Dec 9, 2018

MKleusberg added a commit that referenced this issue Dec 9, 2018

Don't show misleading "determining row count" message in empty db
When no table is selected in the Browse Data tab, either because the
current database is empty or because no database is opened, we would
forever show the "determining row count" message even though nothing is
to be determined at this point. This commit makes sure to show a better
"0 - 0 of 0" message as we did before.

See issue #1654.
@MKleusberg

This comment has been minimized.

Copy link
Member

MKleusberg commented Dec 9, 2018

Yeah, I agree. That's definitely misleading. Should be fixed with the latest commit 😄

@MKleusberg MKleusberg self-assigned this Dec 9, 2018

@justinclift

This comment has been minimized.

Copy link
Member Author

justinclift commented Dec 9, 2018

Thanks. I'm upgrading the version of macOS on our build mac at the moment (mostly waiting for downloads to finish). Will generate the various nightly builds after that's done. 😄

Can't really put it off either (doh!) , as it turns out the version of macOS (El Capitan) we're running is too old now. Homebrew, which we rely on for our development bits, no longer works on it (as of today). So, upgrade day. 🤷‍♂️

@karim

This comment has been minimized.

Copy link
Member

karim commented Dec 9, 2018

Is this related to #1649?

@justinclift

This comment has been minimized.

Copy link
Member Author

justinclift commented Dec 10, 2018

macOS upgrade on the build server seems like it'll be ok. Did a test run using a spare external hdd, then built both Win+macOS nightlies using the test upgrade and they seem ok. Going through the actual (real) upgrade now.

@justinclift

This comment has been minimized.

Copy link
Member Author

justinclift commented Dec 13, 2018

Just had a chance to try this out, but immediately found a (very minor) bug.

Now (running latest master code), if I'm on the Browse Data tab with the empty tab, the row count is correctly shown as "0 - 0 of 0":

1

While still in the Browse Data tab, if I then open a different database (with data in it), the drop down showing the table name is correctly updated. But the widget showing the table contents doesn't get populated:

2

Pressing the Refresh button gets the data to display though:

3

It's probably just some event either not firing, or not being listened to.


Looks like the "determining row count" bug can still be triggered by this too. 😉

If I'm viewing a table with data in it:

3

... but then load the empty database while I'm still in the Browse Data tab, the "determining row count" line is shown (forever) again. 😉

4

mgrojo added a commit that referenced this issue Feb 17, 2019

Don't show misleading "determining row count" message in empty db
When no table is selected in the Browse Data tab, either because the
current database is empty or because no database is opened, we would
forever show the "determining row count" message even though nothing is
to be determined at this point. This commit makes sure to show a better
"0 - 0 of 0" message as we did before.

See issue #1654.

# Conflicts:
#	src/sqlitetablemodel.cpp

@justinclift justinclift referenced this issue Feb 17, 2019

Closed

3.11.1 - outstanding pieces #1747

12 of 13 tasks complete
@justinclift

This comment has been minimized.

Copy link
Member Author

justinclift commented Feb 18, 2019

Closing this as the original issue has been fixed, and the follow up one has it's own issue report now. 😄

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.