Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

About Info - display 32bit vs 64bit #1660

Closed
JReally opened this Issue Dec 14, 2018 · 8 comments

Comments

Projects
None yet
4 participants
@JReally
Copy link

JReally commented Dec 14, 2018

Should the about info also include whether it's a 64 bit vs 32 bit version?

@justinclift

This comment has been minimized.

Copy link
Member

justinclift commented Dec 14, 2018

Good thinking @JReally. Yeah, that's probably useful to include in the About dialog. 😄

@mgrojo

This comment has been minimized.

Copy link
Contributor

mgrojo commented Dec 14, 2018

Shouldn't the About window give the same information as our "Bug Report" tool?

Examples:

DB4S v3.11.99 (Dec 5 2018) on Windows 7 SP 1 (6.1) (winnt/6.1.7601) [x86_64]
using SQLite Version 3.26.0
and Qt 5.11.2

DB4S v3.11.99 (Dec 13 2018) on Ubuntu 18.04.1 LTS (linux/4.15.0-42-generic) [x86_64]
using SQLite Version 3.15.2
and Qt 5.9.5

Having said that, x86_64 is only stating the CPU architecture (QSysInfo::currentCpuArchitecture()), and not what the application is using. There's another function: QSysInfo::buildAbi(), "Returns the full architecture string that Qt was compiled for". Would that necessarily match the architecture that the application was compiled for?

But in any case we should consider merging both texts.

@justinclift

This comment has been minimized.

Copy link
Member

justinclift commented Dec 14, 2018

Shouldn't the About window give the same information as our "Bug Report" tool?

Yep. 😄

I wonder if the 32 and 64-bit windows installers show up differently in that. Will check that quickly now...

@justinclift

This comment has been minimized.

Copy link
Member

justinclift commented Dec 14, 2018

From the 32-bit nightly build, running on 64-bit Win7:

DB4S v3.11.99 (Dec 14 2018) on Windows 7 SP 1 (winnt/6.1.7601) [x86_64]
using SQLite Version 3.26.0
and Qt 5.7.1

From the 64-bit nightly build, running on 64-bit Win7:

DB4S v3.11.99 (Dec 14 2018) on Windows 7 SP 1 (6.1) (winnt/6.1.7601) [x86_64]
using SQLite Version 3.26.0
and Qt 5.12.0

Very similar output. The Qt version is the obvious difference, as we're stuck with Qt 5.7.1 on the 32-bit to give us WinXP support. The only other difference seems to be the (6.1) text fragment on the first line.

That QSysInfo::buildAbi() call might be useful to add too, if it helps tell us clearly which architecture DB4S was compiled for so we don't have to guess (eg based on Qt version). 😄

MKleusberg added a commit that referenced this issue Dec 25, 2018

Show current platform and destination platform information
Add the destination platform from the compilation process and the
platform we are running on to the About dialog and the Bug Report
template text.

See issue #1660.
@MKleusberg

This comment has been minimized.

Copy link
Member

MKleusberg commented Dec 25, 2018

I've added the QSysInfo::buildAbi() information to the About dialog and the Bug Report text. It's a bit verbose but that shouldn't matter too much 😄 Anybody wants to test this?

@justinclift

This comment has been minimized.

Copy link
Member

justinclift commented Dec 25, 2018

Yep. Looks useful. Here's a screenshot from my new-ish CentOS 7 dev workstation just now:

db4s_about_centos7_x64

And yeah, the SQLite version bundled with CentOS 7 is very old. Last updated ~2015.

Haven't checked if the FTS3 module in that is exploitable (Magellan). Not sure I want to look. 😉

@mgrojo

This comment has been minimized.

Copy link
Contributor

mgrojo commented Dec 25, 2018

This is my about text (Ubuntu 18.04):

Version 3.11.99 (Dec 25 2018)

Built for x86_64-little_endian-lp64, running on x86_64

Qt Version 5.9.5

SQLite Version 3.15.2

@MKleusberg

This comment has been minimized.

Copy link
Member

MKleusberg commented Dec 26, 2018

Awesome, I'll close this issue then. Thanks for pointing this out, @JReally! 😄

@MKleusberg MKleusberg closed this Dec 26, 2018

mgrojo added a commit that referenced this issue Feb 17, 2019

Show current platform and destination platform information
Add the destination platform from the compilation process and the
platform we are running on to the About dialog and the Bug Report
template text.

See issue #1660.

@justinclift justinclift added this to the 3.11.1 milestone Feb 17, 2019

@justinclift justinclift referenced this issue Feb 17, 2019

Closed

3.11.1 - outstanding pieces #1747

12 of 13 tasks complete
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.