Join GitHub today
GitHub is home to over 31 million developers working together to host and review code, manage projects, and build software together.Sign up
The "Import CSV" dialog doesn't always display the preview #720
Details for the issue
With DB4S git master (b7be134 as of 10th 2016), the "Import CSV" dialog isn't always displaying the preview image correctly.
As a data point, noticed this when testing the new Russian translation.
Some helpful points to try are mentioned in that issue.
Also worth noting, is that with a different CSV file to import the behaviour changed. Instead of not displaying the preview, instead it displayed what seems like corrupted data:
That's from a CSV export of a database with some PNG files in their cells. The PNG data seems to be quoted (though I've not checked it's correctness), so it's possible either the export or import function isn't handling binary data well.
As a data point, the CSV RFC doesn't define a way to encode binary data.
Wonder what it would take to create a follow up RFC, filling in some of these edge cases we've noticed are missing:
This was referenced
Sep 19, 2017
added a commit
Sep 29, 2017
Cool, good to hear that the missing preview issue is gone
As for the other issue: I've just pushed a commit that fixes the sluggish UI by limiting the length of the cell contents in the preview table. Importing binary data also seems to work way better than expected, so I would leave it as is. Exporting binary data to CSV seems to be pretty broken but we'll have to see if it's worth fixing.