Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Some issues with the plot feature #950

Closed
MKleusberg opened this issue Jan 27, 2017 · 18 comments
Closed

Some issues with the plot feature #950

MKleusberg opened this issue Jan 27, 2017 · 18 comments
Assignees
Labels

Comments

@MKleusberg
Copy link
Member

@MKleusberg MKleusberg commented Jan 27, 2017

Here are some issues @chrisjlocke found in the plotting feature testing the latest version from master. See PR #925 for details.

Initial thoughts:

*   Widget is not disabled when a database is not open
*   When 'Browse Data' tab is clicked on, X axis gets unticked (ie, when user flips from execute SQL to Browse Data) Two 'rowid' rows momentarily exist in the grid, but this is just a quirk of the grid re-populating I think.
*   When an item in the X axis is ticked, ticking another item unticks the original item, but the item you clicked on is not ticked, so you have to click the item you want again.
*   When selecting 'row #' as the X axis, '65536' is displayed as a label, rather than 'row #'.
MKleusberg added a commit that referenced this issue May 8, 2017
In the plot code use the blockSignals() method instead of connecting and
disconnecting signals and slots every time. The disconnects didn't
really work using the new C++11 connection code, so this commit restored
the functionality as it was intended.

This means that *a ton* of calls to updatePlot() are eliminated which
improves the performance.

It also avoid messing up the graph selection table in the Plot Dock in
certain cases.

See issue #950.
MKleusberg added a commit that referenced this issue May 8, 2017
See issue #950.
@MKleusberg
Copy link
Member Author

@MKleusberg MKleusberg commented May 8, 2017

All done 😃 The first one is a little tricky because the widget is disabled, it just doesn't look like it. But that's something we can't do much about...

@chrisjlocke Can you double check that the other three are fixed in the next nightly build? 😃

@chrisjlocke
Copy link
Contributor

@chrisjlocke chrisjlocke commented May 8, 2017

Will do. 😼

@justinclift
Copy link
Member

@justinclift justinclift commented May 17, 2017

@chrisjlocke Ping. 😉

@MKleusberg
Copy link
Member Author

@MKleusberg MKleusberg commented Oct 21, 2017

Ping? 😉

@chrisjlocke
Copy link
Contributor

@chrisjlocke chrisjlocke commented Oct 21, 2017

6 months ago?! Whoops. Sorry!

@chrisjlocke
Copy link
Contributor

@chrisjlocke chrisjlocke commented Oct 31, 2017

Apologies for the delay. Yes, the issues I raised have been resolved. Many thanks!
The only quirk I have now is that if you untick a Y axis field, the axis label is removed. This doesn't happen if the X axis is unticked.

image

So here, the label is showing ap_date, but its unticked. Just a minor thing...

@justinclift
Copy link
Member

@justinclift justinclift commented Dec 7, 2017

This sounds like it might have been fixed a few days ago by 1626345, which cleans up the plot y axis check handling.

@chrisjlocke Do you have time to check it quickly? 😄

@chrisjlocke
Copy link
Contributor

@chrisjlocke chrisjlocke commented Dec 7, 2017

🏃 Am on it...

@chrisjlocke
Copy link
Contributor

@chrisjlocke chrisjlocke commented Dec 7, 2017

Nope. ☹️

Unticking doesn't remove the label.

image

@justinclift
Copy link
Member

@justinclift justinclift commented Dec 7, 2017

Doh! Thanks @chrisjlocke. 😄

k, this sounds like a fairly easy fix though, as @MKleusberg was updating this same section of code the other day. 😄

MKleusberg added a commit that referenced this issue Dec 7, 2017
See issue #950.
@MKleusberg
Copy link
Member Author

@MKleusberg MKleusberg commented Dec 7, 2017

Should be fixed in the next nightly build 😄

@chrisjlocke
Copy link
Contributor

@chrisjlocke chrisjlocke commented Dec 7, 2017

You should make that your signature. 😆

@justinclift
Copy link
Member

@justinclift justinclift commented Dec 7, 2017

I've just manually started the Windows nightly build script again, so in ~1/2 hour we can test this instead of waiting until tomorrow. 😉

@chrisjlocke
Copy link
Contributor

@chrisjlocke chrisjlocke commented Dec 7, 2017

image

@justinclift
Copy link
Member

@justinclift justinclift commented Dec 7, 2017

k, they're built and uploaded. 😄

    https://nightlies.sqlitebrowser.org/latest/

@chrisjlocke
Copy link
Contributor

@chrisjlocke chrisjlocke commented Dec 7, 2017

Ticking Y axis column labels doesn't show anything if the X axis is unticked, but I assume thats not a bug per-se as the operation hasn't completed yet... so I'll shut up otherwise this'll never get closed! ;)

Thanks @MKleusberg for the prompt fix!

@chrisjlocke chrisjlocke closed this Dec 7, 2017
@justinclift
Copy link
Member

@justinclift justinclift commented Dec 7, 2017

Awesome. 😄

@MKleusberg
Copy link
Member Author

@MKleusberg MKleusberg commented Dec 8, 2017

Cool 😄 Thanks again for reporting all these issues, @chrisjlocke 👍

@justinclift justinclift added the bug label Dec 8, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
3 participants