New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve 4k/5k resolution rendering speed on macOS/OSX #1233

Merged
merged 2 commits into from Nov 20, 2017

Conversation

Projects
None yet
2 participants
@SourceTrigger
Copy link
Contributor

SourceTrigger commented Nov 20, 2017

On macOS in 4k and 5k resolutions the program runs very slowly. For Qt to render via OpenGL, a QOpenGLWidget must be added.

SourceTrigger added some commits Nov 20, 2017

OpenGL rendering on macOS
Initialize OpenGL rendering on macOS by add a hidden QOpenGLWidget.
@justinclift

This comment has been minimized.

Copy link
Member

justinclift commented Nov 20, 2017

Thanks @SourceTrigger. I'll try building this and running it on OSX, Windows, and Linux some time today, just to make sure no unexpected weirdness shows up.

If all goes well, this'll be merged after that. 😄

@justinclift justinclift added the osx label Nov 20, 2017

@justinclift justinclift self-assigned this Nov 20, 2017

@justinclift justinclift changed the title Source trigger patch mac os Improve 4k/5k resolution rendering speed on macOS/OSX Nov 20, 2017

@justinclift

This comment has been minimized.

Copy link
Member

justinclift commented Nov 20, 2017

Excellent. Builds and works ok here on Win 7, Linux (Fedora 25 x64), and OSX 10.11.6 (non 4k/5k resolution though).

Thanks for reporting this and getting it fixed. We wouldn't have even known about it otherwise. 😄

@justinclift justinclift merged commit de2131d into sqlitebrowser:master Nov 20, 2017

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details

@SourceTrigger SourceTrigger deleted the SourceTrigger:SourceTrigger-patch-macOS branch Nov 20, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment