New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Source trigger patch file drop #1236

Merged
merged 3 commits into from Nov 20, 2017

Conversation

Projects
None yet
3 participants
@SourceTrigger
Copy link
Contributor

SourceTrigger commented Nov 20, 2017

This fixes the problem that the application crashes when dragging a file to a non-valid index in the table. At the same time the file will be opened in this case.

I add a Signal/Slot to communicate with ExtendTableWidget and MainWindow and validate Index after drop anything.

SourceTrigger added some commits Nov 20, 2017

Check if Index is valid
Send Signal and return if Index is invalid and File was dropped

@SourceTrigger SourceTrigger referenced this pull request Nov 20, 2017

Closed

App crash when you open an sqlite file #1175

3 of 14 tasks complete
@justinclift

This comment has been minimized.

Copy link
Member

justinclift commented Nov 20, 2017

Thanks for doing this @SourceTrigger!

Hopefully @MKleusberg or @mgrojo have time to review this in the next day or two. 😄

@MKleusberg

This comment has been minimized.

Copy link
Member

MKleusberg commented Nov 20, 2017

Thanks a lot, @SourceTrigger, looks good 👍

@MKleusberg MKleusberg merged commit 0a99542 into sqlitebrowser:master Nov 20, 2017

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details

SourceTrigger added a commit to SourceTrigger/sqlitebrowser that referenced this pull request Nov 20, 2017

Merge pull request #1 from sqlitebrowser/master
Source trigger patch file drop (sqlitebrowser#1236)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment