Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Save current filter, sort column and display formats as a new view #1246

Merged
merged 3 commits into from Dec 1, 2017

Commits on Nov 30, 2017

  1. Save current filter, sort column and display formats as a new view

    A new button is added to the Browse Data tab for saving the current display
    of the table (current filter, sort column and display formats) as a new
    view. This allows (specially for non advanced users) the creation of simple
    views. It can be seen, either as a way of storing the current
    filtering or as an easy way of creating views.
    
    This reuses the query set in sqlitetablemodel, but the column aliases when
    a display format is used has been changed from col%1 to the original column
    names, i.e. format(`orig`) AS `orig`.
    mgrojo committed Nov 30, 2017
    Copy the full SHA
    e5f7456 View commit details
    Browse the repository at this point in the history
  2. Remove no longer used method SqlExecutionArea::saveAsView()

    It was moved to MainWindow for reuse and this copy was no longer used.
    mgrojo committed Nov 30, 2017
    Copy the full SHA
    c1f2306 View commit details
    Browse the repository at this point in the history

Commits on Dec 1, 2017

  1. Fixed issues from @MKleusber's review

    New view name validated with isNull().
    
    Text in information box reworded.
    
    Column names are preserved in the new view, except for the ones with
    display formats, for which an underline is appended in order to fix the
    reported filtering defect.
    mgrojo committed Dec 1, 2017
    Copy the full SHA
    5da3d14 View commit details
    Browse the repository at this point in the history