New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove hardcoded styles from hyperlinks #1286

Merged
merged 1 commit into from Jan 5, 2018

Conversation

Projects
None yet
3 participants
@oscarwcl
Copy link
Contributor

oscarwcl commented Jan 5, 2018

These hardcoded styles are unnecessary, as Qt will automatically add styling to hyperlinks that matches the system theme.

This improves compatibility with Qt themes, especially dark themes, where the hardcoded blue hyperlinks are almost unreadable.

Before:
before

After:
after

Remove hardcoded styles from hyperlinks
These hardcoded styles are unnecessary, as Qt will automatically
add styling to hyperlinks that matches the system theme.
@justinclift

This comment has been minimized.

Copy link
Member

justinclift commented Jan 5, 2018

Thanks @oscarwcl. 😄 Yep, this sounds useful. No downsides are really springing to mind either.

Looking over the change quickly, nothing pops out as likely bad. Haven't tried compiling it yet though, probably won't today either. Maybe tomorrow, if no-one else has gotten to this already. 😄

@MKleusberg

This comment has been minimized.

Copy link
Member

MKleusberg commented Jan 5, 2018

Yep, that really makes sense to change. Thanks, @oscarwcl 😄

@MKleusberg MKleusberg merged commit 14da8dc into sqlitebrowser:master Jan 5, 2018

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment