Join GitHub today
GitHub is home to over 31 million developers working together to host and review code, manage projects, and build software together.Sign up
Fix crash when Tab is pressed at the last cell of a view's grid #1289
The crash is avoided if the table model is not editable, since insertRows
I open this pull request:
referenced this pull request
Jan 8, 2018
Thanks, @mgrojo, good catch!
For #141 we will need a different approach than just reverting back. Actually view editing is already partly implemented and relies on the "Pseudo PK" setting (named like that for lack of a better term) in the SqliteTableModel class. So if the isEditable() function is called for a view, we need to check if there is a pseudo-PK before returning true.
But I will just merge this PR now and add the view bits in a second