New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add VERSIONINFO for Windows executable #1387

Merged
merged 1 commit into from May 12, 2018

Conversation

Projects
None yet
2 participants
@karim
Copy link
Member

karim commented May 12, 2018

No description provided.

@karim karim requested a review from justinclift May 12, 2018

@karim

This comment has been minimized.

Copy link
Member Author

karim commented May 12, 2018

versioninfo

@justinclift

This comment has been minimized.

Copy link
Member

justinclift commented May 12, 2018

Good idea. I have no clue personally as to whether this will negatively affect anything else (eg non-windows), but we can give it a go. 😄

With the Travis failure, it looks like one of the two compile tests worked fine (good), but the other failed due to Travis infrastructure problems. eg nothing to do with this PR.

I'll merge this now, and we can look over the resulting Windows builds tomorrow to make sure they're good + fine tune things a bit if needed. 😄

@justinclift justinclift merged commit 1865272 into sqlitebrowser:master May 12, 2018

1 check failed

continuous-integration/travis-ci/pr The Travis CI build could not complete due to an error
Details
@karim

This comment has been minimized.

Copy link
Member Author

karim commented May 12, 2018

Yes, it is just a Windows thing. The .rc is used by Windows Resource Compiler, so I doubt that it will affect anything else.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment