New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make install paths configurable #1443

Merged
merged 1 commit into from Jul 3, 2018

Conversation

Projects
None yet
3 participants
@hasufell
Copy link
Contributor

hasufell commented Jun 22, 2018

No description provided.

@justinclift

This comment has been minimized.

Copy link
Member

justinclift commented Jun 22, 2018

Looks good to me. 😄

The Travis failure is just a transient infrastructure problem with the Travis servers. Seems to happen occasionally, and isn't something to panic about. 😄

@mgrojo

This comment has been minimized.

Copy link
Contributor

mgrojo commented Jul 3, 2018

This seems a positive addition without any (apparent) drawback. I'd like to merge it, but I cannot use qmake for compiling in my Ubuntu 16.04. I've restarted the Travis build and, although it has now succeeded, it isn't using qmake either, so the check is for this case irrelevant.

So, @justinclift, shall we wait for Martin's review or can we considered it trivial to merge?

@justinclift justinclift merged commit 9174abe into sqlitebrowser:master Jul 3, 2018

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
@justinclift

This comment has been minimized.

Copy link
Member

justinclift commented Jul 3, 2018

@mgrojo Good point. Let's merge it, and if something seems to go wrong we can fix that afterwards. 😄

Thanks for getting this done @hasufell. Sorry it took so long to get around to merging. 😇

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment