New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

i18n: Start Polish translation #1456

Merged
merged 1 commit into from Jul 10, 2018

Conversation

Projects
None yet
3 participants
@m4sk1n
Copy link
Contributor

m4sk1n commented Jul 1, 2018

No description provided.

@m4sk1n m4sk1n changed the title i18n: Add Polish translation i18n: Start Polish translation Jul 1, 2018

@@ -226,7 +226,8 @@ set(SQLB_TSS
"${CMAKE_SOURCE_DIR}/src/translations/sqlb_es_ES.ts"
"${CMAKE_SOURCE_DIR}/src/translations/sqlb_fr.ts"
"${CMAKE_SOURCE_DIR}/src/translations/sqlb_ru.ts"
"${CMAKE_SOURCE_DIR}/src/translations/sqlb_pt_BR.ts"
"${CMAKE_SOURCE_DIR}/src/translations/sqlb_pl.ts"

This comment has been minimized.

@justinclift

justinclift Jul 1, 2018

Member

Seems like a spacing issue here. Would you be ok to match the existing style? 😄

@justinclift

This comment has been minimized.

Copy link
Member

justinclift commented Jul 1, 2018

Thanks @m4sk1n, this looks like a good start. 😄

Would you be ok to add the flag icon as well? It doesn't seem to be included yet.

We've been using the one's here, though the parent repo receives more update's these days, so maybe use that instead? 😄

@m4sk1n

This comment has been minimized.

Copy link
Contributor Author

m4sk1n commented Jul 1, 2018

Ok, I’ll fix these two issues today.

@justinclift

This comment has been minimized.

Copy link
Member

justinclift commented Jul 1, 2018

Thanks @m4sk1n. 😄

i18n: Add Polish translation
Signed-off-by: Marcin Mikołajczak <me@m4sk.in>
@justinclift

This comment has been minimized.

Copy link
Member

justinclift commented Jul 3, 2018

@m4sk1n Let me know when you feel this is ready for merging, and I'll give it a technical review. 😄

@m4sk1n

This comment has been minimized.

Copy link
Contributor Author

m4sk1n commented Jul 3, 2018

I don’t know how to generate proper flag icon 😕

@justinclift

This comment has been minimized.

Copy link
Member

justinclift commented Jul 3, 2018

Ahhh, no worries. We can take care of the flag bit then. Is the translation itself complete enough to include at the moment?

If it is, we'll merge this now and get the flag added afterwards. 😄

@justinclift

This comment has been minimized.

Copy link
Member

justinclift commented Jul 9, 2018

@m4sk1n ping?

@MKleusberg

This comment has been minimized.

Copy link
Member

MKleusberg commented Jul 10, 2018

@justinclift According to Qt Linguist it's 590 out of 921 strings. In reality it's probably a bit higher because some strings don't need to be translated ('PK' for example). The untranslated strings are often tooltips and similar texts. So I would guess that, while there is still much left to be translated, this is a pretty good start and probably already helpful for some people.

@m4sk1n Shall we merge this as-is? You can always open more pull requests in the future to finish the translation. Also, I can add the flag for you - no problem 😄

@m4sk1n

This comment has been minimized.

Copy link
Contributor Author

m4sk1n commented Jul 10, 2018

You can merge it, I’ll finish it in the future.

@MKleusberg

This comment has been minimized.

Copy link
Member

MKleusberg commented Jul 10, 2018

Ok cool. Thank you, @m4sk1n! 👍 I'll add the flag in a second.

@MKleusberg MKleusberg merged commit 44920ce into sqlitebrowser:master Jul 10, 2018

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details

MKleusberg added a commit that referenced this pull request Jul 10, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment