Join GitHub today
GitHub is home to over 31 million developers working together to host and review code, manage projects, and build software together.
Sign upChange project file format to support multiple sort columns #1593
Conversation
MKleusberg
requested a review
from
mgrojo
Oct 27, 2018
MKleusberg
added this to the 3.11.0 - Where we take over the world! :D milestone
Oct 27, 2018
MKleusberg
added
the
enhancement
label
Oct 27, 2018
mgrojo
approved these changes
Oct 29, 2018
I've reviewed the code changes and test it a bit and haven't seen anything that could be a problem. I think it can be merged. If this finally enters the 3.11 release, I'll have to update the example described in: https://github.com/sqlitebrowser/sqlitebrowser/wiki/Project-Files |
MKleusberg
changed the title
Change project file format to suppor multiple sort columns
Change project file format to support multiple sort columns
Oct 30, 2018
MKleusberg
force-pushed the
project_file_sort_order
branch
from
93aaed9
to
a3e7e83
Oct 30, 2018
This comment has been minimized.
This comment has been minimized.
Thanks for double checking, Manuel! I'll merge this then and cherry-pick it to the v3.11.x branch. I have also already updated the Wiki page (thanks for the reminder!) and fixed the title of the commit message ('suppor' -> 'support') |
MKleusberg
merged commit 1da7ca8
into
master
Oct 30, 2018
1 check was pending
continuous-integration/travis-ci/pr
The Travis CI build is in progress
Details
added a commit
that referenced
this pull request
Oct 30, 2018
MKleusberg
deleted the
project_file_sort_order
branch
Oct 30, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
MKleusberg commentedOct 27, 2018
This commit changes the project file format (and some internal data
structures) to support multiple sort columns in the Browse Data tab.
Note that this does not add actual support for multiple sort columns,
it's just a preparation for that.
I want to cherry-pick this over to the v3.11.x branch. I think that's pretty handy because for 3.11 we already changed the project file format quite a bit and ask the users to re-save their files. This means these changes here are just on top of that. So when we add support for multiple sort columns one day, we won't have to change the project file format again. However, since the changes here won't get much testing before the release I hope you can have a quick look at the code and check if there are any obvious problems in there😄