New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change project file format to support multiple sort columns #1593

Merged
merged 1 commit into from Oct 30, 2018

Conversation

Projects
None yet
2 participants
@MKleusberg
Copy link
Member

MKleusberg commented Oct 27, 2018

This commit changes the project file format (and some internal data
structures) to support multiple sort columns in the Browse Data tab.
Note that this does not add actual support for multiple sort columns,
it's just a preparation for that.

I want to cherry-pick this over to the v3.11.x branch. I think that's pretty handy because for 3.11 we already changed the project file format quite a bit and ask the users to re-save their files. This means these changes here are just on top of that. So when we add support for multiple sort columns one day, we won't have to change the project file format again. However, since the changes here won't get much testing before the release I hope you can have a quick look at the code and check if there are any obvious problems in there 馃槃

@mgrojo

mgrojo approved these changes Oct 29, 2018

Copy link
Contributor

mgrojo left a comment

I've reviewed the code changes and test it a bit and haven't seen anything that could be a problem. I think it can be merged.

If this finally enters the 3.11 release, I'll have to update the example described in: https://github.com/sqlitebrowser/sqlitebrowser/wiki/Project-Files

@MKleusberg MKleusberg changed the title Change project file format to suppor multiple sort columns Change project file format to support multiple sort columns Oct 30, 2018

Change project file format to support multiple sort columns
This commit changes the project file format (and some internal data
structures) to support multiple sort columns in the Browse Data tab.
Note that this does not add actual support for multiple sort columns,
it's just a preparation for that.

@MKleusberg MKleusberg force-pushed the project_file_sort_order branch from 93aaed9 to a3e7e83 Oct 30, 2018

@MKleusberg

This comment has been minimized.

Copy link
Member Author

MKleusberg commented Oct 30, 2018

Thanks for double checking, Manuel! I'll merge this then and cherry-pick it to the v3.11.x branch. I have also already updated the Wiki page (thanks for the reminder!) and fixed the title of the commit message ('suppor' -> 'support') 馃槈

@MKleusberg MKleusberg merged commit 1da7ca8 into master Oct 30, 2018

1 check was pending

continuous-integration/travis-ci/pr The Travis CI build is in progress
Details

MKleusberg added a commit that referenced this pull request Oct 30, 2018

Change project file format to support multiple sort columns (#1593)
This commit changes the project file format (and some internal data
structures) to support multiple sort columns in the Browse Data tab.
Note that this does not add actual support for multiple sort columns,
it's just a preparation for that.

@MKleusberg MKleusberg deleted the project_file_sort_order branch Oct 30, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment