Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Korean translation #1567 #1600

Closed
wants to merge 32 commits into from

Conversation

Projects
None yet
10 participants
@progh2
Copy link
Contributor

progh2 commented Nov 2, 2018

Hi~ I have not translated all yet.
There are a lot of changes~ 馃拑

justinclift and others added some commits Oct 8, 2018

Problems with WITHOUT ROWID tables with PK of string type (#1559)
* Problems with WITHOUT ROWID tables with PK of string type

This fixes two related problems:
- When the PK is updated the hidden column 0 must be updated too,
  otherwise any further editing of the same row before a table refresh is
  broken.
- When a new record is inserted and the PK has string type we cannot
  simply make a pseudo auto-increment and insert that value as rowid
  because that added key would be impossible to update because our
  UPDATE clause will try to update a column with a string and it contains
  an integer. In this case it's better to let the user enter the PK value,
  so the new Add Record dialog is directly invoked.

See issue #1332 and (tangentially) #1049. The first should be fixed now.
The later not, but at least there is now a workaround: removing the
AUTOINCREMENT option and use the WITHOUT ROWID one.

* Problems with WITHOUT ROWID tables with PK of string type (alternative 2)

Update after review:

- cached_row is not modified after unlock();

- Alternative solution to initial key value insertion:
  When a new record is inserted and the PK has string type we still make a
  pseudo auto-increment and insert that value as a string literal. In this
  way we can later update that row. When we inserted it as integer an
  actual integer will be inserted by SQLite, and our UPDATE clause, which
  always uses string in the WHERE condition, won't match the row (SQLite
  does not convert to integer when the column is of type string in this
  context).

See issue #1332.
Leaving the loading of extensions enabled might be a security risk (#鈥
鈥1558)

* Leaving the loading of extensions enabled might be a security risk

Using sqlite3_enable_load_extension not only allows loading extensions
through the C-API but also through the SQL functioon load_extension().
That might be a security risk if the user is unaware that executing an
SQL file can lead to native code execution and not only to database file
modification.

See issue #1551

* Preference for allowing loading extensions from SQL code

New setting that authorizes the execution of load_extension() from SQL
code. Default value, false, following the design decision of SQLite, that
disables this function unless by default.

Added notice about the option in the calltips of the two function
variants.
Updated Spanish translation (#1574)
Updated Spanish translation for v3.11.0-alpha1 branch and some consistency changes.
Update of translation files for PR #1558
There are two new strings in Preferences (an option and its tooltip) and
two functions call-tips that are updated with this appendix:
"Use of this function must be authorized from Preferences."

Line number changes have been discarded after lupdate so the amount of
changes for merging of translation pull requests are minimised.
Should always translate to "banco de dados"
This improves overall consistency.
Unlock view status was lost after switching view or refresh (#1565)
This solves these two problems that seem to have being introduced in
d5a0490

- The unlocked-view status was not applied again when switching back to the
view (you cannot edit and the Delete Record button is not reenabled) or
after refreshing.

- The 'Unlock view editing' check state persisted when switching between
views.

See issue #141.
Better error handling in import CSV dialog
Make sure to show the correct error message when there is an error
during CSV import.

Make sure to release the DB handle used for the import before rolling
back to the last savepoint in case of an error in the CSV import. This
avoids a deadlock situation.

See issue #1590.
French translation updated for the 3.11 release
Authored by @mvt91

# Conflicts:
#	src/translations/sqlb_fr.ts
Change project file format to support multiple sort columns (#1593)
This commit changes the project file format (and some internal data
structures) to support multiple sort columns in the Browse Data tab.
Note that this does not add actual support for multiple sort columns,
it's just a preparation for that.

progh2 added some commits Nov 3, 2018

@justinclift justinclift changed the base branch from master to v3.11.x Nov 3, 2018

@justinclift justinclift changed the base branch from v3.11.x to master Nov 3, 2018

@justinclift

This comment has been minimized.

Copy link
Member

justinclift commented Nov 3, 2018

Hmmm, something seems not quite right with this PR. It's including a lot of unrelated commits, and I'm not sure why.

When you have it ready for merging, we should be able to grab the individual commits and get them added manually. Shouldn't be too hard. 馃槃

@progh2 progh2 closed this Nov 3, 2018

@justinclift

This comment has been minimized.

Copy link
Member

justinclift commented Nov 4, 2018

@progh2

This comment has been minimized.

Copy link
Contributor Author

progh2 commented Nov 5, 2018

Sorry.
I will resend PR after all complete translation.

@Zaipee

This comment has been minimized.

Copy link

Zaipee commented on src/MainWindow.cpp in 66ffa5f Nov 25, 2018

if(m_browseTableModel->insertRow(row)) {

This comment has been minimized.

Copy link
Member

justinclift replied Nov 25, 2018

?

@justinclift justinclift referenced this pull request Dec 14, 2018

Closed

3.11.0 release - outstanding pieces? #1656

12 of 23 tasks complete

justinclift added a commit that referenced this pull request Apr 3, 2019

justinclift added a commit that referenced this pull request Apr 3, 2019

@justinclift

This comment has been minimized.

Copy link
Member

justinclift commented Apr 3, 2019

@progh2 I've just added the new translations from your PR here to our development source code (5de6ade), and to the v3.11.x (5ff520c) source code we're using for the 3.11.x release series. These updated will be in todays 3.11.2 release. 馃槃

Thanks for taking the time to do the translation, and sorry for the delay in merging it.

@justinclift justinclift referenced this pull request Apr 3, 2019

Closed

3.11.2 - outstanding pieces #1773

13 of 13 tasks complete
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can鈥檛 perform that action at this time.