New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Portuguese translation for v3.11.x #1707

Merged
merged 1 commit into from Jan 10, 2019

Conversation

Projects
None yet
3 participants
@bernardosulzbach
Copy link
Contributor

bernardosulzbach commented Jan 10, 2019

This should cover it.

The "Sources and Forms" pane is empty for Portuguese, but apparently it works in other languages. Can anyone who knows about Linguist give some insight?

screenshot from 2019-01-10 05-28-59

@justinclift

This comment has been minimized.

Copy link
Member

justinclift commented Jan 10, 2019

Thanks @bernardosulzbach. 😄

That blank text box is weird. Maybe it's due to my using an older version of the Qt lupdate program to generate the .ts files, instead of the most recent?

I'll merge this as is, then re-generate the pt_BR strings in the v3.11.x branch using the latest Qt version of lupdate. Lets see if that makes a difference. 😄

@justinclift justinclift merged commit a3658de into sqlitebrowser:v3.11.x Jan 10, 2019

@justinclift

This comment has been minimized.

Copy link
Member

justinclift commented Jan 10, 2019

Downloading the newest Qt again now. It's going slow, so might be a later on tonight thing (or even tomorrow). 😄

@justinclift

This comment has been minimized.

Copy link
Member

justinclift commented Jan 10, 2019

Trying stuff out now. Like yourself, the "Sources and forms" panel isn't working when I try the pt_BR .ts file. This time around I'm using Qt Linguist that comes with Qt 5.12.0.

It's working ok with the de .ts file though.

qt_linguist-sources_and_forms

Not sure how useful that is, but maybe loading the de one for guidance when needed would work?

@mgrojo

This comment has been minimized.

Copy link
Contributor

mgrojo commented Jan 10, 2019

For some reason the Portuguese translation file lacks source code locations and then linguist doesn't show the widgets or source code quotes. Probably the file was created with this command line:

lupdate -locations none sqlitebrowser.pro

And then lupdate continues respecting how the file was created. I've been able to fix it executing this:

lupdate -locations absolute sqlitebrowser.pro

I've not commited the result, because it is probably better that you do it yourself in your branch, so there are no conflicts later, @bernardosulzbach.

There is an advantage in lacking source code locations: the translation file is then not changing only because the surrounding code has changed. But all the other languages have them, and lacking the context while translating is worse than having trivial changes in the files related to line numbers. I guess you'll prefer to ammend the file.

@mgrojo

This comment has been minimized.

Copy link
Contributor

mgrojo commented Jan 10, 2019

I've not commited the result, because it is probably better that you do it yourself in your branch, so there are no conflicts later, @bernardosulzbach.

Forget about this, I see now that the pull request is already merged. But I leave it to you nevertheless, unless you want me to commit it.

@bernardosulzbach

This comment has been minimized.

Copy link
Contributor Author

bernardosulzbach commented Jan 10, 2019

But all the other languages have them, and lacking the context while translating is worse than having trivial changes in the files related to line numbers.

I agree. In Portuguese and many other languages, we must know how a verb is being used to translate it correctly, so context is even more crucial than for English.

Forget about this, I see now that the pull request is already merged. But I leave it to you nevertheless, unless you want me to commit it.

It would be very kind of you @mgrojo to do it for me.

mgrojo added a commit that referenced this pull request Jan 10, 2019

Add source code locations to Portuguese translation file
Otherwise linguist doesn't show the widgets or source code references.

See PR #1707
@mgrojo

This comment has been minimized.

Copy link
Contributor

mgrojo commented Jan 10, 2019

Of course, no problem. Done.

Best wishes.

mgrojo added a commit that referenced this pull request Jan 10, 2019

Add source code locations to Portuguese translation file
Otherwise linguist doesn't show the widgets or source code references.

See PR #1707
@justinclift

This comment has been minimized.

Copy link
Member

justinclift commented Jan 11, 2019

lupdate -locations none sqlitebrowser.pro

I think I just ran lupdate src/src.pro, as that's what I wrote on the wiki ages ago:

    https://github.com/sqlitebrowser/sqlitebrowser/wiki/Release-process

Should that be updated to have:

lupdate -locations absolute sqlitebrowser.pro

... instead?

@justinclift

This comment has been minimized.

Copy link
Member

justinclift commented Jan 11, 2019

We'll probably need to update all the translation files then, as I updated them all at the same time a while back. So, the problem likely exists in them all. 😦

@justinclift

This comment has been minimized.

Copy link
Member

justinclift commented Jan 11, 2019

Reading back, I misunderstood. So it was likely a problem with how the file was created.

Are you able to check if the new Persian language file has the same problem? It was created recently, but I'm not sure what command I used to create it. 😄

@mgrojo

This comment has been minimized.

Copy link
Contributor

mgrojo commented Jan 11, 2019

Are you able to check if the new Persian language file has the same problem? It was created recently, but I'm not sure what command I used to create it. 😄

The Persian file is OK. The TS files have the problem when they are explicitly created with lupdate -locations none file.pro. The default value for -locations in the creation is absolute (what we want). And then, while updating the file, the default is respecting whatever format the file currently has.

@justinclift

This comment has been minimized.

Copy link
Member

justinclift commented Jan 11, 2019

Thanks @mgrojo. 😄

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment