New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New Czech translations #1710

Merged
merged 2 commits into from Jan 12, 2019

Conversation

Projects
None yet
3 participants
@MrJiggers
Copy link
Contributor

MrJiggers commented Jan 12, 2019

No description provided.

@justinclift

This comment has been minimized.

Copy link
Member

justinclift commented Jan 12, 2019

Thanks @MrJiggers. 😄

Are these based on the master branch, or the v3.11.x branch?

It makes a difference, as the strings are slightly different between them. The v3.11.x branch is what the new release will be created from.

@MrJiggers

This comment has been minimized.

Copy link
Contributor Author

MrJiggers commented Jan 12, 2019

Hi @justinclift, yeah it's based on the master, is it a problem? 😁 I didn't know that i should do it in a different branch, sorry.

@mgrojo mgrojo merged commit 623a4d6 into sqlitebrowser:master Jan 12, 2019

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
@mgrojo

This comment has been minimized.

Copy link
Contributor

mgrojo commented Jan 12, 2019

Don't worry, @MrJiggers. I think we can still apply it to the v3.11.x branch. The only problem might be that some translations could not apply to the v3.11.x, but given that it is still not complete, it doesn't make much difference.

mgrojo added a commit that referenced this pull request Jan 12, 2019

New Czech translations (#1710)
Used PR version and run through lupdate so it is in sync to the v3.11.x
branch.

# Conflicts:
#	src/translations/sqlb_cs.ts
@mgrojo

This comment has been minimized.

Copy link
Contributor

mgrojo commented Jan 12, 2019

It's already in both branches.

This is from the master branch compilation log:

     Generated 676 translation(s) (359 finished and 317 unfinished)
     Ignored 319 untranslated source text(s)

And this is from the v3.11.x branch:

     Generated 673 translation(s) (356 finished and 317 unfinished)
     Ignored 334 untranslated source text(s)
@justinclift

This comment has been minimized.

Copy link
Member

justinclift commented Jan 13, 2019

No worries. It looks like they're both about 2/3 complete, so it's progressing decently.

Thanks for taking the time to get this done @MrJiggers. 😄

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment