Fix incorrect version in Finder's Info view

[revolter]

Related to #551.

Fix similar to QupZilla/qupzilla#1486.

[justinclift]

Awesome. 😄

[justinclift]

Note - Just waiting for the Travis CI build to ok this, Just In Case. 😉

(and no, not expecting it to fail)

[vtronko]

Why don't just push it, since diff is straightforward and not ambiguous(thus no discussion needed) 😄

[justinclift]

Yeah, ok. You convinced me. 😀

[revolter]

Because I don't trust myself yet to directly push changes without PR. Don't want to make mistakes like #655 x_x

[justinclift]

Absolutely nothing wrong in being cautious when you feel like it. 😄

[vtronko]

Yet, just IMO huge amount of merge commits pollutes the log.
Good work on issues btw 👍

[justinclift]

Lots of merge commits do look pretty nifty in the Network graph though. Whooo! 😁

[revolter]

@innermous, Ok, I'll push trivial changes directly. And, thanks 😄

[vtronko]

It's so miserable glitch, that I won't even open another issue for that.
In this about dialog in version label you can put cursor blink in any random position. It feels a bit awkward.
@justinclift should this be left just as is?

[justinclift]

Up to you. If you want to adjust it, go for it. 😄

[revolter]

@innermous, I don't think it's a good idea. It actually was intentional as seen in #222. Apple does that too:

so you can easily copy and paste the version when asked for. I agree it should leave the cursor there, blinking, but disabling selecting is not a good idea.

Also, being able to select the text "Version" is not great also, but it can't be easily done in the current state, as it's just a big string.

[justinclift]

Hmmm, yeah. I'd completely forgotten about #222. 😵

Just tried out 109ead9 here, and the version text isn't selectable at all with that.

So, it sounds like the optimal approach would be to have the text be selectable, but without any kind of blinking cursor. Is that achievable?

[revolter]

@justinclift, Done 😄

[justinclift]

Thanks @revolter, that's great!

Just tried it here, and yep it's selectable & no cursor seems present. All good. 😄

[revolter]

My first "direct" commit also 😄

[vtronko]

@revolter alrighty then. I forgot about copy-paste use case.

[revolter]

No problem