Corrects some typos and tildes #924

Merged
merged 2 commits into from Jan 10, 2017

Projects

None yet

3 participants

@lulol
Contributor
lulol commented Jan 8, 2017

Corrects some typos and tildes since the latest update. 😄

@justinclift
Member

Awesome @lulol!

Are these ok to merge as is, or should we take screenshots of them in action first, or ? 😄

@MKleusberg

I've added one comment to this PR but other than that this looks good to me.
@justinclift Probably no need for screenshots I guess, but I'll let @lulol decide 😃
@lulol Thanks a lot for the work you've put into this 👍

src/translations/sqlb_es_ES.ts
@@ -2333,7 +2333,7 @@ Do you want to insert it anyway?</source>
</message>
<message>
<location filename="../MainWindow.ui" line="1891"/>
- <source>Copy the CREATE statement of the item to the clipboard</source>
+ <source>Copy the CREATE statement of the ítem to the clipboard</source>
@MKleusberg
MKleusberg Jan 8, 2017 Member

Not sure here because this changes the source string (= the original English text), not the Spanish one.

@lulol
lulol Jan 8, 2017 edited Contributor

@MKleusberg Ooops. 😢 Fixed.

@justinclift Now think that are ok to merge as is.

Although for some couldn't find the dialogs where are actually being used, these are just fixed typos. All of them hopefully.

But in the GUI I'm still seeing those same untranslated strings that seemed to be translated in the .ts like that in line="14" and line="1309" but the others are not even defined there.

portapapeles01
portapapeles02

@justinclift
justinclift Jan 10, 2017 Member

@lulol Interesting. Some of those I was able to find using grep:

Main window

Preferences pialog

Does that help? 😄

@justinclift justinclift merged commit bd0b863 into sqlitebrowser:master Jan 10, 2017

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
@MKleusberg
Member

Thanks, @lulol 👍 I think, in order to have those missing strings included in the translation file, you'll need to re-run Qt Linguist on the application. Unfortunately I have no experience with that whatsoever...

@justinclift
Member

Ahhh, I can do that and commit the results if it would help. @lulol ?

@justinclift
Member

@MKleusberg It can be done from Qt Creator. Tools → External → Linguist → Update translations (lupdate)

@lulol
Contributor
lulol commented Jan 11, 2017

@justinclift We could try and see how it works out in the next nightly build.

@justinclift
Member

@lulol Good thinking. 😄

Just committed an updated Spanish .ts file (generated from lupdate): e4fdb8f

Take a look at it and see if it seems correct to you. If it is, we can commit an update for the other .ts files as well. 😄

@lulol
Contributor
lulol commented Jan 11, 2017

@justinclift I see that now among the 55 strings tagged "unfinished" are those that previously were missing in the .ts.

Should I translate them now? So that we can check before changing them for all the languages, if in the next nightly build also the other strings already translated but not showing in the GUI like "Edit Database Cell" and "DB Schema" are also fixed.

@justinclift
Member

Sure, if you want. 😄

@lulol
Contributor
lulol commented Jan 12, 2017

@justinclift Done, and PR ready. Hope that it works and the new generated files finally fix the missing translations for all the languages. 😄

@justinclift
Member

Excellent @lulol, that was very quick! I needed to get sleep, so missed getting the PR merged right away (now done).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment