Skip to content

HTTPS clone URL

Subversion checkout URL

You can clone with
or
.
Download ZIP

Loading…

Use users app sound as default #58

Closed
ghost opened this Issue · 3 comments

1 participant

@ghost

Right now the default sound is set to PushoverSound. There is no way I can set it to the default sound from the android app. According to the api docs:

If no sound parameter is specified, the user's default tone will play. If the user has not chosen a custom sound, the standard Pushover sound will play.

So I guess $this->setSound(new PushoverSound); should be removed from the Message class: https://github.com/sqmk/Pushy/blob/master/library/Pushy/Message.php#L88

Not sure if that alone is enough. Maybe also line 58 in SendMessage should have a check: https://github.com/sqmk/Pushy/blob/master/library/Pushy/Command/SendMessage.php#L58

Probably something like: if ($this->message->getSound()) set sound. This way the sound parameter is not send if it is empty. But maybe it's not needed and only the first change is enough.

@sqmk
Owner

Understood. Not passing a sound to the API would play the default sound? I can probably add this pretty quickly.

@sqmk sqmk self-assigned this
@sqmk sqmk referenced this issue from a commit
@sqmk GitHub #58 - Spaces 16e8918
@sqmk
Owner

This should now be complete.

@sqmk sqmk closed this
@ghost

Thank you. This seems to work as expected now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Something went wrong with that request. Please try again.