Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add `--reset-author` flag #148

Merged
merged 3 commits into from Sep 3, 2019

Conversation

@sqren
Copy link
Owner

commented Sep 1, 2019

Closes #146

Add --reset-author flag which makes it possible to change the commit author to yourself.
This is useful when the original commit was made by a bot and the the CLA check needs to be bypassed.

Example usage:

backport --reset-author

@spalger

@sqren sqren force-pushed the add-reset-author-flag branch from 4ed072d to 3d28d41 Sep 1, 2019

@spalger

This comment has been minimized.

Copy link
Contributor

commented Sep 3, 2019

LGTM, tested with elastic/kibana#44717, but I used the documented --resetAuthor flag, do both kebab and camel case flags work?

@sqren

This comment has been minimized.

Copy link
Owner Author

commented Sep 3, 2019

I used the documented --resetAuthor flag, do both kebab and camel case flags work?

@spalger Good point. Yes both work due to the way yargs-parser works.

I've now replaced --resetAuthor with --reset-author in the docs for consistency. I've also added a test that verifies this behaviour on the cli level.

@sqren sqren force-pushed the add-reset-author-flag branch from 47c58ae to 2676177 Sep 3, 2019

@sqren sqren merged commit 79fdc7c into master Sep 3, 2019

3 checks passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details
coverage/coveralls Coverage decreased (-0.2%) to 87.522%
Details

@sqren sqren deleted the add-reset-author-flag branch Sep 3, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.