Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Send access token via auth header #165

Merged
merged 1 commit into from Feb 10, 2020

Conversation

@sqren
Copy link
Owner

sqren commented Feb 6, 2020

Github is deprecating sending access token via query param. Instead it should be sent over auth header

https://developer.github.com/changes/2019-11-05-deprecated-passwords-and-authorizations-api/#authenticating-using-query-parameters

Closes #164

Github is deprecating sending access token via query param. Instead it should be sent over auth header

https://developer.github.com/changes/2019-11-05-deprecated-passwords-and-authorizations-api/#authenticating-using-query-parameters
@sqren sqren merged commit 82f08d0 into master Feb 10, 2020
3 checks passed
3 checks passed
continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details
coverage/coveralls Coverage remained the same at 83.867%
Details
@sqren sqren deleted the send-access-token-via-auth-instead-of-query-param branch Feb 10, 2020
@sqren sqren mentioned this pull request Feb 11, 2020
@sqren

This comment has been minimized.

Copy link
Owner Author

sqren commented Feb 14, 2020

Released in v4.9.0

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

1 participant
You can’t perform that action at this time.