Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix crash when opening AboutActivity #632

Merged
merged 1 commit into from Oct 28, 2019

Conversation

@cmargonis
Copy link
Contributor

cmargonis commented Oct 27, 2019

Problem

The app crashes whenever the AboutActivity initializes. More info in #631.

Solution

The solution was to add the missing applicationComponent when building theDaggerAboutComponent.

Test(s) added

No tests were added/modified.

Screenshots

No UI modification.

Paired with

Nobody.

This fixes issue #631.
@quiro91

This comment has been minimized.

Copy link
Collaborator

quiro91 commented Oct 28, 2019

Thanks a lot @cmargonis !

@quiro91 quiro91 merged commit 86426d9 into squanchy-dev:develop Oct 28, 2019
4 checks passed
4 checks passed
ci/circleci: checkout Your tests passed on CircleCI!
Details
ci/circleci: prepare_for_checks Your tests passed on CircleCI!
Details
ci/circleci: static_analysis Your tests passed on CircleCI!
Details
ci/circleci: tests Your tests passed on CircleCI!
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.