Skip to content

Automatically enable accessibility on the device also#93

Merged
puls merged 2 commits into
kif-framework:masterfrom
sgleadow:enable-accessibility-on-device
Nov 15, 2011
Merged

Automatically enable accessibility on the device also#93
puls merged 2 commits into
kif-framework:masterfrom
sgleadow:enable-accessibility-on-device

Conversation

@sgleadow

Copy link
Copy Markdown
Contributor

My previous pull request for enabling accessibility on the device. After some comments on my blog post about it, I modified the code to also run on the device. I wrote up my findings on another blog post

Without this code, when I run KIF on a device without VoiceOver on, the accessibility values are not available to KIF and the test fails. With this code, the values become available automatically and the tests can run on the device.

@puls

puls commented Nov 15, 2011

Copy link
Copy Markdown
Contributor

Awesome, but I'd change the name of the method from _enableAccessibilityInSimulator to something more general.

@sgleadow

Copy link
Copy Markdown
Contributor Author

Good catch, I missed that completely. I have renamed the method to be general

puls added a commit that referenced this pull request Nov 15, 2011
Automatically enable accessibility on the device also
@puls puls merged commit 87b535b into kif-framework:master Nov 15, 2011
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants