Request http body is required in PDNetworkDomainController #25

Closed
gr4yscale opened this Issue Oct 25, 2012 · 1 comment

Comments

Projects
None yet
3 participants
@gr4yscale
Contributor

gr4yscale commented Oct 25, 2012

Hi guys, when trying to make a request that has no HTTP body, we get a crash in PDNetworkDomainController.

The fix was simply a matter of changing this line:

if (contentType && [contentType rangeOfString:@"json"].location != NSNotFound) {

to this:

if (body && contentType && [contentType rangeOfString:@"json"].location != NSNotFound) {

I was going to submit a pull request, but didn't see the option so I guess you guys aren't taking pull requests at this time. Just wanted to let you guys know.

INCREDIBLE work, by the way. I'm a big fan of square and everything they're doing.

@mikelikespie

This comment has been minimized.

Show comment
Hide comment
@mikelikespie

mikelikespie Oct 26, 2012

Collaborator

@gr4yscale Thanks for this find. We do take pull requests. Github just moved the button. It is on top now in the center. Please make sure to sign the CLA as well.

Collaborator

mikelikespie commented Oct 26, 2012

@gr4yscale Thanks for this find. We do take pull requests. Github just moved the button. It is on top now in the center. Please make sure to sign the CLA as well.

@wlue wlue closed this Oct 30, 2012

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment