PonyDebugger causing modals to dismiss without animation #35

Closed
adamhowardprice opened this Issue Dec 6, 2012 · 5 comments

Projects

None yet

3 participants

@adamhowardprice

I've found an issue with all modals in my app that are being dismissed with [self dismissModalViewControllerAnimated:YES completion:nil];

When I have PonyDebugger enabled, every modal dismisses without animation. When I turn it off, the modals dismiss with animation like normal.

@ryanolsonk
Contributor

Do you have PonyDebugger's view hierarchy debugging enabled?

@adamhowardprice

Commenting out the line
[debugger enableViewHierarchyDebugging];
also fixes the modal animation.

@wlue
Collaborator
wlue commented Dec 10, 2012

I've had this issue as well. It only happens with default modal animations (the horizontal flip modal animation still works).

@ryanolsonk
Contributor

Good catch! I made a mistake in the swizzled exchangeSubviewAtIndex:withSubviewAtIndex: which was responsible. I will open a pull request later tonight.

Reminds me of one of my favourite Cocoa selector names (from UIViewController):

attentionClassDumpUser:yesItsUsAgain:althoughSwizzlingAndOverridingPrivateMethodsIsFun:itWasntMuchFunWhenYourAppStoppedWorking:pleaseRefrainFromDoingSoInTheFutureOkayThanksBye:

@wlue wlue closed this Dec 12, 2012
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment