Skip to content

HTTPS clone URL

Subversion checkout URL

You can clone with
or
.
Download ZIP

Loading…

PonyDebugger causing modals to dismiss without animation #35

Closed
adamhowardprice opened this Issue · 5 comments

3 participants

@adamhowardprice

I've found an issue with all modals in my app that are being dismissed with [self dismissModalViewControllerAnimated:YES completion:nil];

When I have PonyDebugger enabled, every modal dismisses without animation. When I turn it off, the modals dismiss with animation like normal.

@ryanolsonk

Do you have PonyDebugger's view hierarchy debugging enabled?

@adamhowardprice

Commenting out the line
[debugger enableViewHierarchyDebugging];
also fixes the modal animation.

@wlue
Collaborator

I've had this issue as well. It only happens with default modal animations (the horizontal flip modal animation still works).

@ryanolsonk

Good catch! I made a mistake in the swizzled exchangeSubviewAtIndex:withSubviewAtIndex: which was responsible. I will open a pull request later tonight.

Reminds me of one of my favourite Cocoa selector names (from UIViewController):

attentionClassDumpUser:yesItsUsAgain:althoughSwizzlingAndOverridingPrivateMethodsIsFun:itWasntMuchFunWhenYourAppStoppedWorking:pleaseRefrainFromDoingSoInTheFutureOkayThanksBye:

@wlue wlue closed this
@davidapgar davidapgar referenced this issue from a commit
Commit has since been removed from the repository and is no longer available.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Something went wrong with that request. Please try again.