Skip to content

HTTPS clone URL

Subversion checkout URL

You can clone with
or
.
Download ZIP

Loading…

Fix for Issue #35 #37

Merged
merged 1 commit into from

2 participants

@ryanolsonk

There was a typo in the swizzled UIView method, exchangeSubviewAtIndex:withSubviewAtIndex:, which caused the actual method to be called with the wrong parameters. This fixes issue #35.

@ryanolsonk ryanolsonk Fix swizzling mistake in exchangeSubviewAtIndex:withSubviewAtIndex:
This was causing modal views to dismiss without the
UIModalTransitionStyleCoverVertical animation, and possibly
other issues.
e912986
@wlue
Collaborator

LGTM. Thanks for the pull request!

@wlue wlue merged commit 90ca09c into square:master
@davidapgar davidapgar referenced this pull request from a commit
Commit has since been removed from the repository and is no longer available.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Commits on Dec 12, 2012
  1. @ryanolsonk

    Fix swizzling mistake in exchangeSubviewAtIndex:withSubviewAtIndex:

    ryanolsonk authored
    This was causing modal views to dismiss without the
    UIModalTransitionStyleCoverVertical animation, and possibly
    other issues.
This page is out of date. Refresh to see the latest.
Showing with 1 addition and 1 deletion.
  1. +1 −1  ObjC/PonyDebugger/PDDOMDomainController.m
View
2  ObjC/PonyDebugger/PDDOMDomainController.m
@@ -823,7 +823,7 @@ - (void)pd_swizzled_exchangeSubviewAtIndex:(NSInteger)index1 withSubviewAtIndex:
{
[[PDDOMDomainController defaultInstance] removeView:[[self subviews] objectAtIndex:index1]];
[[PDDOMDomainController defaultInstance] removeView:[[self subviews] objectAtIndex:index2]];
- [self pd_swizzled_exchangeSubviewAtIndex:index1 withSubviewAtIndex:index1];
+ [self pd_swizzled_exchangeSubviewAtIndex:index1 withSubviewAtIndex:index2];
[[PDDOMDomainController defaultInstance] addView:[[self subviews] objectAtIndex:index1]];
[[PDDOMDomainController defaultInstance] addView:[[self subviews] objectAtIndex:index2]];
}
Something went wrong with that request. Please try again.