False positive for "coding" declaration regex #31

Closed
mislav opened this Issue Aug 29, 2012 · 2 comments

Comments

Projects
None yet
2 participants
Contributor

mislav commented Aug 29, 2012

The regex is too liberal. It finds the following class as undocumented:

module FaradayMiddleware
  # Public: Parse a Transfer-Encoding: Chunked response to just the original data
  class Chunked < FaradayMiddleware::ResponseMiddleware
    TRANSFER_ENCODING = 'transfer-encoding'.freeze
    # ...
  end
end

mislav added a commit to lostisland/faraday_middleware that referenced this issue Aug 29, 2012

lock to Cane v1.x
Cane 2 wrongly reports that a class which has a preceding comment is not
documented. References square/cane#31

Closes #49
Contributor

xaviershay commented Aug 29, 2012

argh good call. Will have a chance to fix in the next couple of days.

Contributor

xaviershay commented Aug 30, 2012

Fixed in 2.2.2.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment