Fix rule.remove and rule.metric #49

Open
wants to merge 1 commit into
from

Projects

None yet

1 participant

@jra3
jra3 commented Apr 4, 2013

The data bound to rule was inconsistently either an integer or an object with
an integer attribute i. This affected both rule.remove in that it tried to
remove a listener using this data, and the styling of rules drawn from
rule.metric which is used to draw rules at specific times to denote events such as deployments (which is apparently undocumented, but super useful). These are the divs classed as "metric line" in the code. This functionality was introduced here c4d23ab

Attached is an example of rules drawn using rule.metric
rulemetric

This pull request picks up of of #40

@jra3 jra3 Fix rule.remove and rule.metric
The data bound to rule was inconsistently either an integer or an object with
an integer attribute i.  This affected both rule.remove in that it tried to
remove a listener using this data, and the styling of rules drawn from
rule.metric (which is apparently undocumented, but super useful)
a13639d
@jra3
jra3 commented May 16, 2013

Any feedback on the axis.remove() fix?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment