Make ObjectGraph itself an abstract type #173

Merged
merged 1 commit into from Feb 27, 2013

Conversation

Projects
None yet
3 participants
Collaborator

cgruber commented Feb 27, 2013

Make ObjectGraph itself an abstract type with five abstract contract methods (plus the static create()), moving the implementation into a static inner class.

@cgruber cgruber Make ObjectGraph itself an abstract type with five abstract contract …
…methods (plus the static create()), moving the implementation into a static inner class.
c19d382
Collaborator

cgruber commented Feb 27, 2013

This is one of those diff-tools suck moments. The actual diff of this is much less serious, except that the inner static implementation class (which is unchanged except for comments and @Overrride annotations, is indented two spaces. This, however, foils diff and github's diffing, apparently.

Le sigh.

swankjesse was assigned Feb 27, 2013

@swankjesse swankjesse added a commit that referenced this pull request Feb 27, 2013

@swankjesse swankjesse Merge pull request #173 from cgruber/abstractgraph
Make ObjectGraph itself an abstract type
6b75b8a

@swankjesse swankjesse merged commit 6b75b8a into square:master Feb 27, 2013

1 check passed

default The Travis build passed
Details
Contributor

swankjesse commented Feb 27, 2013

Heads up, this might be a binary incompatible change since we're turning final methods into abstract methods.

Collaborator

pforhan commented Feb 27, 2013

@cgruber Try adding ?w=1 to the end of the url in these cases. It'd be nice if GH provided a handy checkbox for this, but at least it's something.

https://github.com/square/dagger/pull/173/files?w=1

@tbroyer tbroyer pushed a commit to tbroyer/dagger that referenced this pull request Jan 21, 2016

@ronshapiro @cgruber ronshapiro + cgruber Remove restriction around generating classes in lowerCamelCase.
This doesn't mean that we should have naming sequences in those patterns, but our types that derive names from inputted types should not jump through hoops to have a style-compliant name.

Addresses Github issue #173
-------------
Created by MOE: https://github.com/google/moe
MOE_MIGRATED_REVID=107509623
b99ae8e
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment