Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes the same issue as CVE-2015-7545. #2

Merged
merged 1 commit into from
Dec 12, 2015
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Fixes the same issue as CVE-2015-7545.
Kudos to Blake Burkhart for pointing this out.
  • Loading branch information
System Administrator committed Dec 12, 2015
commit a8a33f187214185b885a10bcfe2527c74da84a8c
2 changes: 1 addition & 1 deletion .rubocop_todo.yml
Original file line number Diff line number Diff line change
Expand Up @@ -13,7 +13,7 @@ Metrics/AbcSize:
# Offense count: 1
# Configuration parameters: CountComments.
Metrics/ClassLength:
Max: 121
Max: 125

# Offense count: 38
# Configuration parameters: AllowURI, URISchemes.
Expand Down
5 changes: 5 additions & 0 deletions lib/git-fastclone.rb
Original file line number Diff line number Diff line change
Expand Up @@ -247,6 +247,11 @@ def store_updated_repo(url, mirror, repo_name, fail_hard)
# moment means we only need to synchronize our own threads in case a single
# submodule url is included twice via multiple dependency paths
def with_git_mirror(url)
if url.lstrip.start_with?('ext::')
logger.info("Skipping #{url} for security purpose (CVE-2015-7545)") if logger
return
end

update_reference_repo(url, true)

# Sometimes remote updates involve re-packing objects on a different thread
Expand Down