Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Export RandReader for deterministic testing #212

Merged
merged 1 commit into from Dec 20, 2018

Conversation

@jack-stripe
Copy link
Contributor

commented Dec 15, 2018

Hello!

We're using go-jose for a new project, and it'd be quite useful to be able to stub its randomness in tests. The specific kind of test we want to enable is where a partner gives us known inputs to be JWE'd and outputs to compare the results to (which gives us a way of asserting that we're actually invoking go-jose correctly.)

This should be a fully backwards-compatible change, but let me know what you think!

@CLAassistant

This comment has been minimized.

Copy link

commented Dec 15, 2018

CLA assistant check
All committers have signed the CLA.

@jack-stripe

This comment has been minimized.

Copy link
Contributor Author

commented Dec 15, 2018

(re: CLA, I believe my employer has reached out to Square.)

@csstaub

This comment has been minimized.

Copy link
Collaborator

commented Dec 15, 2018

Change looks good to me. If you need help contacting the right person about setting up the CLA just shoot me an email, I’m cs(at)squareup.com.

@csstaub csstaub merged commit e94fb17 into square:v2 Dec 20, 2018
2 checks passed
2 checks passed
continuous-integration/travis-ci/pr The Travis CI build passed
Details
license/cla Contributor License Agreement is signed.
Details
@csstaub

This comment has been minimized.

Copy link
Collaborator

commented Dec 20, 2018

Merged, thanks for the contribution @jack-stripe! If you need me to tag this in a release let me know.

@jack-stripe

This comment has been minimized.

Copy link
Contributor Author

commented Dec 24, 2018

Thanks @csstaub! If you have the chance to tag a release with this that would be great. And thanks again for an excellent library.

@csstaub

This comment has been minimized.

Copy link
Collaborator

commented Jan 2, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
3 participants
You can’t perform that action at this time.