Join GitHub today
GitHub is home to over 28 million developers working together to host and review code, manage projects, and build software together.Sign up
Please add Automatic-Module-Name manifest entries #589
It'd be great if
Of course, full modularization would be better, but
added a commit
Dec 7, 2017
referenced this issue
Dec 7, 2017
We do not want to do that since it can break tools.…
On Thu, Dec 7, 2017 at 2:55 PM Christian Stein ***@***.***> wrote: Adding a module descriptor is not that difficult either -- but needs an upgade to jdk 9. At least for compiling the module-info.java source file. — You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub <#589 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AAEEEasZFh2MUnunnBFzAatndSX8PjALks5s-ELGgaJpZM4Q6FAr> .
On Thu, Dec 7, 2017, 3:12 PM Christian Stein ***@***.***> wrote: You mean having a module-info.class in the root of the JAR file breaks tools? Because it ends with .class and can not be instantiated (or ignored) by older Java runtimes and custom class parsers/loaders? — You are receiving this because you commented. Reply to this email directly, view it on GitHub <#589 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AAEEEWi87CEgfZM__S7cdtQdiNi8Qi13ks5s-EaQgaJpZM4Q6FAr> .