Jetpack with Capistrano and external jar dependencies #11

Closed
wants to merge 3 commits into
from

Projects

None yet

3 participants

@jpalley
jpalley commented Apr 17, 2012

Note: this is our first time using Jetty. These fixes allowed us to use jetpack with capistrano and other jar dependencies. If not suitable/correct pls let us know!

  1. Removes RAILS_ENV requirement in jetty-init if app_type is not rails.
  2. Uses @path_to_project for the bundler gem. Given we are setting this anyway and thus have the fullpath, it seemed easier than try to make sure $PATH was setup correctly.
  3. Adds jar_includes to the jetpack.yml file to allow extra jar files to be included. These are inserted into the extraClasspath of the jetty.xml after the jruby jar files.
@michaeldauria michaeldauria commented on the diff May 9, 2012
bin/jetpack
@@ -53,7 +53,7 @@ script_start_time = Time.now
@jetpack_dir = File.expand_path(File.join(File.dirname(__FILE__), ".."))
@gem_home = "file:" + File.expand_path(File.join(@settings.app_root, @jruby_jar_file)) + "!/META-INF/jruby.home/lib/ruby/gems/1.8"
-@gem_path = @gem_home + ":vendor/bundler_gem"
+@gem_path = @gem_home + ":#{File.expand_path(File.join(@path_to_project, "vendor/bundler_gem"))}"
michaeldauria
michaeldauria May 9, 2012

if you're going to use File.join, might as well go all the way with it:

@gem_path = @gem_home + ':' + File.expand_path(File.join(@path_to_project, 'vendor', 'bundler_gem'))
Contributor

Closing stale. Sorry this got ignored. Feel free to rebase and resubmit if it's still relevant.

@xaviershay xaviershay closed this Feb 5, 2013
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment