This repository has been archived by the owner on Feb 7, 2020. It is now read-only.
Reloading keystore #33
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Since the jetpack.ssl.ReloadingSslContextFactory is really an extension to jetty and not something needed by the web app context we should compile it into a jar and put it in #{jetty.home/lib/ext instead. |
|
@cheister I pushed the updates we discussed. Please let me know if it would be more clear to squash commits and start another PR. |
sul3n3t
pushed a commit
that referenced
this pull request
Jul 26, 2013
This reverts commit 425347d. The downstream dependency should be resolved.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@cheister or @tamird
This adds similar keystore reloading functionality as in our java repo. Would you please review, particularly compilation, cmdline args, and attempt at testing? Overall the tests are till broken; not sure what the deal is with bundler deps missing in test. It works when you run the script on the sample project though.