Join GitHub today
GitHub is home to over 40 million developers working together to host and review code, manage projects, and build software together.
Sign upAdd back writeTo(Filer) and originating element APIs #647
Conversation
This comment has been minimized.
This comment has been minimized.
|
Will rebase this tomorrow |
ZacSweers
added a commit
to square/moshi
that referenced
this pull request
Mar 26, 2019
This adds support for incremental compilation in gradle via incap helper and marking the code gen as `ISOLATING`. Depends on a newer version of KotlinPoet that has square/kotlinpoet#647 Resolves #589
ZacSweers
added a commit
to square/moshi
that referenced
this pull request
Mar 26, 2019
This adds support for incremental compilation in gradle via incap helper and marking the code gen as `ISOLATING`. Depends on a newer version of KotlinPoet that has square/kotlinpoet#647 Resolves #589
|
Looks good, thanks! |
src/main/java/com/squareup/kotlinpoet/OriginatingElementsHolder.kt
Outdated
Show resolved
Hide resolved
src/main/java/com/squareup/kotlinpoet/OriginatingElementsHolder.kt
Outdated
Show resolved
Hide resolved
ZacSweers
added a commit
to square/moshi
that referenced
this pull request
Apr 18, 2019
This adds support for incremental compilation in gradle via incap helper and marking the code gen as `ISOLATING`. Depends on a newer version of KotlinPoet that has square/kotlinpoet#647 Resolves #589
ZacSweers
added a commit
to square/moshi
that referenced
this pull request
Apr 18, 2019
* Support gradle incremental processing in code gen This adds support for incremental compilation in gradle via incap helper and marking the code gen as `ISOLATING`. Depends on a newer version of KotlinPoet that has square/kotlinpoet#647 Resolves #589 * Opportunistically update to auto-service 1.0-rc5 Supports incremental compilation and moves annotations to a separate artifact * 1.2.0 final! * Mark compiler embeddales as test only
ShaishavGandhi
added a commit
to ShaishavGandhi/kotlinpoet
that referenced
this pull request
Aug 14, 2019
* Initial pass at OriginatingElement interface * Wire in OriginatingElementsHolder to TypeSpec * Remove unnecessary return type * Read nested elements as well in TypeSpec * Add back TestFiler * Opportunistic use idiomatic map assignment * Use kt for source file * Add FakeElement for Element instance testing use * Add back FileSpec.writeTo() with original FileWriting and TypeSpec tests From square@d24e4af * Add List<Element> buildOriginatingElements extension * Add originating elements to FunSpec * Add originating elements to PropertySpec * Add a mixed file to tests * Add toBuilder tests * Don't error on non-originating elements members * Formatting and copyright fixes * Opportunistic add missing copyright to taggable files * Back to 2014 * Revert "Opportunistic add missing copyright to taggable files" This reverts commit 1858c44.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
ZacSweers commentedMar 14, 2019
•
edited
Resolves #105
This adds back the
FileSpec#writeTo(File)API and originating element APIs onTypeSpec, as well as spreading support for originating elements ontoPropertySpecandFunSpec(since you could have files with no types). Most of this was borrowed from the original revert in d24e4afThis uses a simpler version of the interface pattern
Taggableuses to reuse the logic and make integrating it simple inFileSpec.