Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Consider making androidx.startup Initializers part of the public API #2393

Closed
fbarthelery opened this issue Jun 27, 2022 · 1 comment · Fixed by #2397
Closed

Consider making androidx.startup Initializers part of the public API #2393

fbarthelery opened this issue Jun 27, 2022 · 1 comment · Fixed by #2397
Labels
type: enhancement
Milestone
2.10

Comments

@fbarthelery
Copy link
Contributor

Problem description

Androidx startup initializers allows to specify dependencies via the dependencies() method. This helps to determine the runtime order of the intializers. However, Leakcanary initializers are internals and not part of the public api so they can't be specified as dependencies.

Potential solutions

Declare initializers as public classes
@pyricau
Copy link
Member

pyricau commented Jun 28, 2022

Seems like a fair ask. PRs welcome.

fbarthelery added a commit to fbarthelery/leakcanary that referenced this issue Jun 29, 2022
@fbarthelery
make androidx.startup Initializers public
7ddb473 
Fixes square#2393
@fbarthelery fbarthelery mentioned this issue Jun 29, 2022
Merged
@pyricau pyricau added this to the 2.10 milestone Aug 22, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
type: enhancement
Projects
None yet
Milestone
2.10
Development

Successfully merging a pull request may close this issue.

make androidx.startup Initializers public fbarthelery/leakcanary
2 participants
@pyricau @fbarthelery