Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(modal,dialog,popover)!: add composables for modal/dialog/popover layers #555

Merged
merged 3 commits into from
Jul 12, 2023

Conversation

tatems
Copy link
Collaborator

@tatems tatems commented Jun 22, 2023

Describe the problem this PR addresses

This PR makes some changes to the modal, dialog, and popover layers to allow initialization of the layers to be done via composables instead of mixins. This is to support components that use the composition API in Vue 2.7.14 (and eventually Vue 3.x).

Describe the changes in this PR

  • Convert modal, dialog, and popover APIs to be able to be initialized by either mixin or composable
  • Add documentation for changes
  • Require Vue 2.7.14

@tatems tatems changed the title feat!(modal,dialog,popover): vue 2.7 required, add composables for modal/dialog/popover layers feat!(modal,dialog,popover): add composables for modal/dialog/popover layers Jun 22, 2023
@tatems tatems changed the title feat!(modal,dialog,popover): add composables for modal/dialog/popover layers feat(modal,dialog,popover)!: add composables for modal/dialog/popover layers Jun 28, 2023
@github-actions
Copy link

Deployed Styleguide and Lab.

Notes
  1. Links may take a few minutes to update after PR is opened or commit is pushed.
  2. Links may become invalidated after PR is merged or closed.
  3. Links for all releases and open PRs can be found on the Maker Deploys page.

@tatems tatems marked this pull request as ready for review July 5, 2023 14:01
@tatems tatems requested review from a team as code owners July 5, 2023 14:01
@tatems tatems merged commit e82fa1b into master Jul 12, 2023
3 checks passed
@tatems tatems deleted the composables branch July 12, 2023 18:14
@github-actions
Copy link

🎉 This PR is included in version 19.0.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants