New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added support for vim-airline #85

Closed
wants to merge 7 commits into
from

Conversation

Projects
None yet
6 participants
@sebdah
Contributor

sebdah commented Sep 10, 2013

Added support for vim-airline. This closes #36 and rules out #55.

@eventualbuddha

This comment has been minimized.

Show comment
Hide comment
@eventualbuddha

eventualbuddha Sep 10, 2013

Collaborator

I'm definitely interested in this (and would use it myself). My concern is that it might be too opinionated/different from stock vim. Thoughts?

Collaborator

eventualbuddha commented Sep 10, 2013

I'm definitely interested in this (and would use it myself). My concern is that it might be too opinionated/different from stock vim. Thoughts?

@sebdah

This comment has been minimized.

Show comment
Hide comment
@sebdah

sebdah Sep 10, 2013

Contributor

I must say that you might have a point here. It would be preferred to:

  • Have airline toggled off by default
  • Disable the buffer toolbar (in the top) by default

I know how to do the latter but I do not know how to fix the first. There is a command available for this inside vim; AirlineToggle, maybe that can be used? Any thoughts or input appreciated.

Contributor

sebdah commented Sep 10, 2013

I must say that you might have a point here. It would be preferred to:

  • Have airline toggled off by default
  • Disable the buffer toolbar (in the top) by default

I know how to do the latter but I do not know how to fix the first. There is a command available for this inside vim; AirlineToggle, maybe that can be used? Any thoughts or input appreciated.

@bling

This comment has been minimized.

Show comment
Hide comment
@bling

bling Sep 10, 2013

Having a statusline plugin that's disabled by default would be a bit weird, but if that's needed to get this merged I'd be happy to add a check. The tabline extension is already disabled by default. Cheers.

bling commented Sep 10, 2013

Having a statusline plugin that's disabled by default would be a bit weird, but if that's needed to get this merged I'd be happy to add a check. The tabline extension is already disabled by default. Cheers.

@sebdah

This comment has been minimized.

Show comment
Hide comment
@sebdah

sebdah Sep 11, 2013

Contributor

I suppose that this all boils down to what the core contributors would like to see. I'm using airline and would be happy to have it turned on by default. If the "impact" is to big having it enabled by default, it would be sufficient to write instructions on how to enable it via ~/.vimrc.local.

It would be great if you could add that functionality @bling.

Ping @rudle @strongriley.

Contributor

sebdah commented Sep 11, 2013

I suppose that this all boils down to what the core contributors would like to see. I'm using airline and would be happy to have it turned on by default. If the "impact" is to big having it enabled by default, it would be sufficient to write instructions on how to enable it via ~/.vimrc.local.

It would be great if you could add that functionality @bling.

Ping @rudle @strongriley.

@bling

This comment has been minimized.

Show comment
Hide comment
@bling

bling Sep 11, 2013

well, the default would be to have it enabled of course (i can't break it for all existing users), with the option to have it disabled.

this means that the default vimrc in maximum-awesome will have a enabled=0, and then the vimrc.local would need a enabled=1 to override it....which seems a bit messy....

bling commented Sep 11, 2013

well, the default would be to have it enabled of course (i can't break it for all existing users), with the option to have it disabled.

this means that the default vimrc in maximum-awesome will have a enabled=0, and then the vimrc.local would need a enabled=1 to override it....which seems a bit messy....

@strongriley

This comment has been minimized.

Show comment
Hide comment
@strongriley

strongriley Sep 12, 2013

Collaborator

Yea, it's a sliding scale - there's nothing that inherently may make a plugin non-standard. The way I'm trying to think about it is: would a novice to vim coming from the IDE world expect this?

@eventualbuddha @rudle I think we need to clarify maximum awesome's goals and non-goals so we can balance opinionated customization, ease of use, etc.

Collaborator

strongriley commented Sep 12, 2013

Yea, it's a sliding scale - there's nothing that inherently may make a plugin non-standard. The way I'm trying to think about it is: would a novice to vim coming from the IDE world expect this?

@eventualbuddha @rudle I think we need to clarify maximum awesome's goals and non-goals so we can balance opinionated customization, ease of use, etc.

@sebdah

This comment has been minimized.

Show comment
Hide comment
@sebdah

sebdah Aug 7, 2014

Contributor

I have written a blog post about how to do this without the pull request, it can be found here: http://sebastiandahlgren.se/2014/08/07/running-vim-airline-with-maximum-awesome/

Contributor

sebdah commented Aug 7, 2014

I have written a blog post about how to do this without the pull request, it can be found here: http://sebastiandahlgren.se/2014/08/07/running-vim-airline-with-maximum-awesome/

@strongriley

This comment has been minimized.

Show comment
Hide comment
@strongriley

strongriley Aug 7, 2014

Collaborator

Thanks for sharing @sebdah. I guess we never reached consensus on how opinionated maximum awesome should be. Glad you were able to customize. That's why the .vimrc.local and .vimrc.bundles.local files exist 😄

Collaborator

strongriley commented Aug 7, 2014

Thanks for sharing @sebdah. I guess we never reached consensus on how opinionated maximum awesome should be. Glad you were able to customize. That's why the .vimrc.local and .vimrc.bundles.local files exist 😄

@josephndenton

This comment has been minimized.

Show comment
Hide comment
@josephndenton

josephndenton Nov 20, 2014

Most vim newcomers I've helped to transition have benefited from airline with hidden set and the buffer bar enabled, with a few leader mappings for next/prev/close buffer. Though, you can achieve much of the same functionality with ctrlp buffer search.

Most vim newcomers I've helped to transition have benefited from airline with hidden set and the buffer bar enabled, with a few leader mappings for next/prev/close buffer. Though, you can achieve much of the same functionality with ctrlp buffer search.

@rudle

This comment has been minimized.

Show comment
Hide comment
@rudle

rudle Mar 11, 2015

Collaborator

Closing this as stale.

Collaborator

rudle commented Mar 11, 2015

Closing this as stale.

@rudle rudle closed this Mar 11, 2015

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment