New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Split of SimpleNetwork, SimpleForm to own library included within @misk/core #137

Open
adrw opened this Issue Feb 6, 2019 · 1 comment

Comments

Projects
1 participant
@adrw
Copy link
Member

adrw commented Feb 6, 2019

  • No downstream of @misk/core tabs needs to change
  • Lets open source people use just the SimpleNetwork Redux wrappers
  • Consider naming the library more broadly so future Redux-Sagas wrappers can be included in it

@adrw adrw added this to To do in adrw via automation Feb 6, 2019

@adrw adrw changed the title Split of SimpleNetwork to own library included within @misk/core Split of SimpleNetwork, SimpleForm to own library included within @misk/core Feb 14, 2019

@adrw

This comment has been minimized.

Copy link
Member Author

adrw commented Feb 14, 2019

Eliminate exports like this by having a non-omnibus package for those functions / features to be pulled in from.

import {
  dispatchSimpleNetwork,
  IDispatchSimpleNetwork,
  ISimpleNetworkState,
  SimpleNetworkReducer,
  simpleNetworkSelector,
  watchSimpleNetworkSagas,
  ISimpleFormState,
  IDispatchSimpleForm,
  dispatchSimpleForm,
  simpleFormSelector,
  SimpleFormReducer,
  watchSimpleFormSagas
} from "@misk/core"
export {
  dispatchSimpleNetwork,
  getSimpleNetwork,
  onClickFnCall,
  onChangeFnCall,
  onChangeNumberFnCall,
  onChangeTagFnCall,
  onChangeToggleFnCall,
  querySimpleForm,
  querySimpleFormData,
  querySimpleNetwork,
  valueSimpleForm,
  valueSimpleFormTags
} from "@misk/core"
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment